Skip to content

fix(literal): use Object.is so literal(NaN) accepts NaN #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spokodev wants to merge 5 commits into
base: main
Choose a base branch
from
+15 −1
Open

fix(literal): use Object.is so literal(NaN) accepts NaN #1529

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32a0e08
fix(literal): use Object.is so literal(NaN) accepts NaN
spokodev Jun 30, 2026
4273438
fix(literal): use SameValueZero so signed zero still matches
spokodev Jul 2, 2026
83dbc16
Merge branch 'main' into fix/literal-nan-object-is
yslpn Jul 21, 2026
cf27646
Merge branch 'main' into fix/literal-nan-object-is
yslpn Jul 24, 2026
c5168a1
chore(literal): apply prettier formatting
spokodev Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions library/src/schemas/literal/literal.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ describe('literal', () => {
expectNoSchemaIssue(literal(45.67), [45.67]);
});

test('for valid NaN literal', () => {
expectNoSchemaIssue(literal(NaN), [NaN]);
});

test('for valid string literal', () => {
expectNoSchemaIssue(literal(''), ['']);
expectNoSchemaIssue(literal('foo'), ['foo']);
Expand Down
2 changes: 1 addition & 1 deletion library/src/schemas/literal/literal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export function literal(
return _getStandardProps(this);
},
'~run'(dataset, config) {
if (dataset.value === this.literal) {
if (Object.is(dataset.value, this.literal)) {
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
Outdated
// @ts-expect-error
Comment thread
coderabbitai[bot] marked this conversation as resolved.
dataset.typed = true;
} else {
Expand Down