fix: use SameValueZero equality for special numeric values by yslpn · Pull Request #1573 · open-circle/valibot

yslpn · 2026-08-02T21:52:39Z

Fix SameValueZero equality for special numeric values

Summary

This change makes value equality consistent across literal, intersect,
value, notValue, values, and notValues.

Problem

JavaScript strict equality and ordering comparisons do not consider NaN equal
to itself. As a result, several APIs rejected a value that was identical to its
configured requirement:

literal(NaN) rejected NaN.
value(NaN) and values([NaN]) rejected NaN.
notValue(NaN) and notValues([NaN]) accepted NaN.
intersect reported a conflict when two branches produced NaN or invalid
Date values for the same entry.

Changes

Adds the internal _sameValueZero utility.
Uses it in literal and _merge.
Uses it before the existing ordering fallback in value, notValue,
values, and notValues.
Preserves the existing behavior for -0 and +0.
Preserves cross-instance comparison of valid Date values in the value
actions.

Tests

Adds regression coverage for:

NaN matching itself in every affected API.
-0 and +0 remaining interchangeable.
Merging two invalid Date objects.

Verification

pnpm -C library test — 520 test files and 4514 tests passed.
pnpm -C library lint — passed without errors.
pnpm -C library format.check — passed.

Acknowledgements

This consolidated fix builds on the work and investigation in:

Closes #1477
Closes #1517
Closes #1529
Closes #1535

Thank you all for identifying the edge cases, proposing fixes, and adding
regression coverage that informed this unified change.

Summary by CodeRabbit

Bug Fixes
- Improved value validation for special numeric values, including NaN and positive or negative zero.
- Corrected literal, value, and collection comparisons for invalid dates and other edge cases.
- Preserved special values correctly when combining data.
Tests
- Added coverage for NaN, signed zero, invalid dates, and value-matching behavior across validation and comparison scenarios.

coderabbitai · 2026-08-02T21:53:08Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c3bbbfae-3d2a-463f-b03b-abc97cfb7f76

📥 Commits

Reviewing files that changed from the base of the PR and between d6b87da and 3ded0bc.

📒 Files selected for processing (2)

library/src/utils/_isValueRequirementMatch/_isValueRequirementMatch.test.ts
library/src/utils/_isValueRequirementMatch/_isValueRequirementMatch.ts

🚧 Files skipped from review as they are similar to previous changes (2)

library/src/utils/_isValueRequirementMatch/_isValueRequirementMatch.ts
library/src/utils/_isValueRequirementMatch/_isValueRequirementMatch.test.ts

Walkthrough

Added _isSameValueZero and _isValueRequirementMatch utilities. Updated value actions to use centralized requirement matching. Updated literal validation and intersection merging to use SameValueZero comparisons. Added tests for NaN, signed zero, equivalent values, and invalid dates.

Possibly related PRs

open-circle/valibot#1517: Updates _merge and its tests for special-value equality.
open-circle/valibot#1529: Adds the original literal(NaN) equality fix.

Suggested reviewers: fabian-hiller

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the primary change: applying SameValueZero equality to special numeric values.
Linked Issues check	✅ Passed	The changes fix NaN matching, literal validation, intersect merging, invalid dates, signed zero, and add regression tests for [`#1477`], [`#1517`], [`#1529`], and [`#1535`].
Out of Scope Changes check	✅ Passed	All implementation and test changes directly support the linked equality fixes and their regression coverage.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-08-02T21:54:05Z

Open in StackBlitz

npm i https://pkg.pr.new/valibot@1573

commit: 3ded0bc

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@library/src/schemas/intersect/utils/_merge/_merge.test.ts`:
- Around line 43-49: Strengthen the invalid-date test around _merge by
explicitly asserting that the merged result value is a Date before validating
its invalid timestamp with Number.isNaN. Keep the existing issue expectation and
timestamp assertion unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c47477ef-e073-4b0a-abe3-984fe7af8d25

📥 Commits

Reviewing files that changed from the base of the PR and between e789528 and f82b648.

📒 Files selected for processing (16)

library/src/actions/notValue/notValue.test.ts
library/src/actions/notValue/notValue.ts
library/src/actions/notValues/notValues.test.ts
library/src/actions/notValues/notValues.ts
library/src/actions/value/value.test.ts
library/src/actions/value/value.ts
library/src/actions/values/values.test.ts
library/src/actions/values/values.ts
library/src/schemas/intersect/utils/_merge/_merge.test.ts
library/src/schemas/intersect/utils/_merge/_merge.ts
library/src/schemas/literal/literal.test.ts
library/src/schemas/literal/literal.ts
library/src/utils/_sameValueZero/_sameValueZero.test.ts
library/src/utils/_sameValueZero/_sameValueZero.ts
library/src/utils/_sameValueZero/index.ts
library/src/utils/index.ts

Copilot

Pull request overview

This PR fixes edge-case equality behavior by introducing a shared SameValueZero comparator and using it across literal/value-based validations and intersect merging, so that NaN (and invalid Date timestamps during merge) can match itself while keeping -0/+0 interchangeable.

Changes:

Added internal _sameValueZero utility (SameValueZero semantics: NaN equals NaN, -0 equals +0) with tests and exported it from the utils barrel.
Updated literal, value, notValue, values, and notValues to use _sameValueZero before (or instead of) existing comparison logic.
Updated intersect’s _merge to use _sameValueZero for both direct equality and Date timestamp equality (including invalid dates), with regression tests.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
library/src/utils/index.ts	Exports the new internal `_sameValueZero` utility.
library/src/utils/_sameValueZero/index.ts	Adds barrel export for the `_sameValueZero` implementation.
library/src/utils/_sameValueZero/_sameValueZero.ts	Introduces SameValueZero comparison helper used across multiple APIs.
library/src/utils/_sameValueZero/_sameValueZero.test.ts	Adds unit coverage for NaN and signed-zero behavior.
library/src/schemas/literal/literal.ts	Uses `_sameValueZero` so `literal(NaN)` works while keeping `-0`/`+0` interchangeable.
library/src/schemas/literal/literal.test.ts	Adds regression tests for NaN and signed-zero literals.
library/src/schemas/intersect/utils/_merge/_merge.ts	Uses `_sameValueZero` for merge equality, including invalid `Date` timestamps.
library/src/schemas/intersect/utils/_merge/_merge.test.ts	Adds regression tests for NaN merges, signed zeros, and invalid dates.
library/src/actions/values/values.ts	Adds `_sameValueZero` short-circuit to correctly match `NaN` in `values`.
library/src/actions/values/values.test.ts	Adds regression test ensuring `values([NaN])` accepts NaN.
library/src/actions/value/value.ts	Adds `_sameValueZero` short-circuit to correctly match `NaN` in `value`.
library/src/actions/value/value.test.ts	Adds regression test ensuring `value(NaN)` accepts NaN.
library/src/actions/notValues/notValues.ts	Adds `_sameValueZero` short-circuit so `notValues([NaN])` correctly rejects NaN.
library/src/actions/notValues/notValues.test.ts	Adds regression test ensuring NaN is rejected for `notValues([NaN])`.
library/src/actions/notValue/notValue.ts	Adds `_sameValueZero` short-circuit so `notValue(NaN)` correctly rejects NaN.
library/src/actions/notValue/notValue.test.ts	Adds regression test ensuring NaN is rejected for `notValue(NaN)`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cubic-dev-ai

All reported issues were addressed across 16 files

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

…N value

fabian-hiller · 2026-08-03T00:50:14Z

Is this a breaking change for some of the modified functions? Can this be released as part of the next v1 release.
I recommend _sameValueZero follows the _is prefix that we use for functions that return a boolean.

ysknsid25

Thank you for your work!
I left a comment that was more like a personal impression 🙏

…ed functions to reuse logic

yslpn · 2026-08-03T21:00:23Z

Is this a breaking change for some of the modified functions? Can this be released as part of the next v1 release.

I consider it a bug fix rather than an API-breaking change. With strict equality, NaN could never match itself, making value(NaN) impossible to satisfy and inverting the expected behavior of the negative actions. The change also aligns these APIs with existing picklist, which already uses SameValueZero semantics via Array.prototype.includes. There are no API or type-level changes. I am comfortable releasing it in the next v1 release. 1.5 for example.

I recommend _sameValueZero follows the _is prefix that we use for functions that return a boolean.

Done

cubic-dev-ai

All reported issues were addressed across 15 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

…d date check

…uirementMatch

fix: use SameValueZero equality for special numeric values

f82b648

Copilot AI review requested due to automatic review settings August 2, 2026 21:52

dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. fix A smaller enhancement or bug fix labels Aug 2, 2026

Copilot started reviewing on behalf of yslpn August 2, 2026 21:53 View session

coderabbitai Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread library/src/schemas/intersect/utils/_merge/_merge.test.ts

Copilot AI reviewed Aug 2, 2026

View reviewed changes

cubic-dev-ai Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread library/src/schemas/intersect/utils/_merge/_merge.test.ts Outdated

fix(_merge.test): ensure invalid dates return a Date instance with Na…

b45e3ed

…N value

yslpn requested review from fabian-hiller and ysknsid25 August 2, 2026 22:08

ysknsid25 reviewed Aug 3, 2026

View reviewed changes

Comment thread library/src/actions/notValue/notValue.ts Outdated

yslpn added 2 commits August 3, 2026 22:12

refactor: rename _sameValueZero with _isSameValueZero

9e151e2

refactor: implement _isValueRequirementMatch utility and update relat…

d6b87da

…ed functions to reuse logic

dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 3, 2026

cubic-dev-ai Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread library/src/utils/_isValueRequirementMatch/_isValueRequirementMatch.ts

ysknsid25 self-requested a review August 3, 2026 23:46

ysknsid25 previously approved these changes Aug 3, 2026

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 3, 2026

yslpn added 3 commits August 4, 2026 23:36

fix: enhance _isValueRequirementMatch to handle invalid Date comparisons

58307ed

fix: simplify _isValueRequirementMatch by removing unnecessary invali…

46acb64

…d date check

fix: add comment to clarify NaN check for invalid Date in _isValueReq…

3ded0bc

…uirementMatch

yslpn dismissed ysknsid25’s stale review via 3ded0bc August 4, 2026 21:42

Navigation Menu

Uh oh!

Uh oh!

fix: use SameValueZero equality for special numeric values - #1573

fix: use SameValueZero equality for special numeric values#1573
yslpn wants to merge 7 commits into
open-circle:mainfrom
yslpn:fix/same-value-zero-equality

yslpn commented Aug 2, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 2, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Aug 2, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

fabian-hiller commented Aug 3, 2026

Uh oh!

ysknsid25 left a comment •

edited

Loading

Uh oh!

Uh oh!

yslpn commented Aug 3, 2026

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

yslpn commented Aug 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix SameValueZero equality for special numeric values

Summary

Problem

Changes

Tests

Verification

Acknowledgements

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

pkg-pr-new Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fabian-hiller commented Aug 3, 2026

Uh oh!

ysknsid25 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yslpn commented Aug 3, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yslpn commented Aug 2, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 2, 2026 •

edited

Loading

pkg-pr-new Bot commented Aug 2, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

ysknsid25 left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading