Implement code points validator by tats-u · Pull Request #888 · open-circle/valibot

tats-u · 2024-10-20T01:58:19Z

Fixes #875

Implemented based on graphemes validation.

Summary by CodeRabbit

New Features
- Added Unicode code point count validators: codePoints, minCodePoints, maxCodePoints, and notCodePoints.
- Each validator supports custom validation messages and properly handles emoji and other multi-code-point strings.
- Added public exports for the new validators and _getCodePointCount.
Documentation
- Added API documentation and type references for all new validators and their action/issue types.
Tests
- Added runtime tests and TypeScript declaration tests covering valid/invalid cases, Unicode edge cases, and _getCodePointCount.

fabian-hiller · 2024-10-20T16:36:10Z

Thank you for creating this PR! I will try to review and merge it in the next weeks. 🙏

tats-u · 2024-10-22T14:45:28Z

I might export the implementation of _getCodePointCoun to other validators (e.g. Zod) in the future.

fabian-hiller · 2024-10-28T03:21:22Z

I just want to let you know that I am focusing on our v1 release first before reviewing this PR.

tats-u · 2024-10-28T03:37:38Z

That's not good news. I'll wait for v1.1.0.
And I want to get permission to publish _getCodePointCount as my independent package from you.
If that function is improved by others, I'll try to get permission from them or keep mine as is.

fabian-hiller · 2024-10-28T03:42:12Z

Yes, feel free to create your own package. No permission required.

vercel · 2025-04-29T12:44:07Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
valibot	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 22, 2025 2:30pm

tats-u · 2025-04-29T12:44:36Z

@fabian-hiller rebased to main (no additional changes)

tats-u · 2025-04-29T13:45:28Z

Fix done. Could you allow this PR to run CIs?

pkg-pr-new · 2025-06-17T02:26:04Z

Open in StackBlitz

npm i https://pkg.pr.new/valibot@888

commit: d4d8c0a

fabian-hiller · 2025-06-17T02:26:14Z

Sorry for my late reply. 😐 I updated the branch and triggered CI.

Copilot

Pull request overview

Copilot reviewed 45 out of 45 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (2)

library/src/actions/codePoints/codePoints.ts:125

The default issue message is built as Invalid ${label} in _addIssue. Using the label code_points will surface an underscore in user-facing messages ("Invalid code_points"). Consider using a human-readable label like code points (matching the docs/terminology).

          _addIssue(this, 'code_points', dataset, config, {

library/src/utils/_getCodePointCount/_getCodePointCount.ts:17

The inline comments are misleading: the last code unit of a JS string can be a lone high surrogate in an ill-formed sequence, and codePointAt(i) can’t be undefined here because the loop bounds keep i in-range. Updating the comments would make the intent clearer without changing behavior.

  // The last code unit of the input cannot be the start of a surrogate pair
  const lengthMinus1 = input.length - 1;
  for (let i = 0; i < lengthMinus1; ) {
    // If codePointAt returned undefined here, we would have already exited the loop
    if (input.codePointAt(i)! <= 65535) {

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

yslpn · 2026-07-26T13:04:55Z

Hi @tats-u Thanks for working on this. Let's continue.

The new APIs from the codePoints family haven't been added to website/src/routes/api/menu.md.
Reread my comment again: Implement code points validator #888 (comment) I think this is important to do.

cubic-dev-ai

All reported issues were addressed across 6 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

yslpn · 2026-08-06T16:46:26Z

@tats-u Hi. Thank you very much. LGTM, I'll send this PR to Fabian for merge.

Please finalize the comments from the AI code review.

UPD:
I will help and make final corrections, you don't need to do anything.

…riptions

cubic-dev-ai

All reported issues were addressed across 8 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 6 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

This reverts commit f64f7ed.

This reverts commit ee49c4d.

tats-u force-pushed the code-points branch from e3e8736 to c00c425 Compare October 20, 2024 09:53

fabian-hiller self-assigned this Oct 20, 2024

fabian-hiller added the enhancement New feature or request label Oct 20, 2024

fabian-hiller force-pushed the main branch 2 times, most recently from f41426c to d713dfe Compare January 4, 2025 00:55

fabian-hiller force-pushed the main branch from d9c65ea to 85f5f35 Compare February 14, 2025 04:53

tats-u added 3 commits April 29, 2025 21:42

Implement code points validator

b15edab

Simplify

27b88b3

Reduce count operations

71b4dd2

tats-u force-pushed the code-points branch from f9fe8c6 to 71b4dd2 Compare April 29, 2025 12:44

vercel Bot had a problem deploying to Preview April 29, 2025 12:44 Failure

'~validate' => '~run' & format

f724c33

vercel Bot deployed to Preview April 29, 2025 13:46 View deployment

Merge branch 'main' into code-points

abec9d1

dosubot Bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jun 17, 2025

fabian-hiller added this to the v1.2 milestone Jun 17, 2025

vercel Bot deployed to Preview June 17, 2025 02:27 View deployment

tats-u added 2 commits June 22, 2025 23:02

Add docs

88fa1e0

Add notCodePoints

0ec38d6

vercel Bot deployed to Preview June 22, 2025 14:30 View deployment

tats-u added 4 commits July 20, 2026 15:34

Fix indent inconsistency

c52ffc2

Fix interface JSDoc

5427714

Change codePoints to code points in JSDoc

6398c4b

Change type to interface in JSDoc

5a2aafa

tats-u requested review from Copilot and yslpn July 20, 2026 06:55

Copilot started reviewing on behalf of tats-u July 20, 2026 06:55 View session

Copilot AI reviewed Jul 20, 2026

View reviewed changes

Comment thread library/src/actions/minCodePoints/minCodePoints.ts Outdated

Comment thread library/src/actions/maxCodePoints/maxCodePoints.ts Outdated

Comment thread library/src/actions/notCodePoints/notCodePoints.ts Outdated

Fix "invalid ..." label

d4d8c0a

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

yslpn requested changes Jul 29, 2026

View reviewed changes

Update docs

44f491d

cubic-dev-ai Bot reviewed Aug 5, 2026

View reviewed changes

Comment thread website/src/routes/api/(actions)/minGraphemes/index.mdx Outdated

Comment thread website/src/routes/api/(actions)/length/index.mdx Outdated

Comment thread website/src/routes/api/(actions)/minLength/index.mdx Outdated

Merge branch 'main' into code-points

6846d19

yslpn self-requested a review August 6, 2026 16:46

yslpn added 4 commits August 6, 2026 22:19

docs: update API documentation to include codePoints and improve desc…

fcf3141

…riptions

fix: correct issue type string from 'code_points' to 'code points'

378c2e5

docs: enhance explanations for code points validation actions

3e8028f

feat: add code points actions support for to-json-schema

ee49c4d

yslpn previously approved these changes Aug 6, 2026

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 6, 2026

cubic-dev-ai Bot reviewed Aug 6, 2026

View reviewed changes

Comment thread packages/to-json-schema/src/converters/convertAction/convertAction.ts Outdated

Comment thread packages/to-json-schema/src/converters/convertAction/convertAction.ts Outdated

fix(to-json-schema): preserve composed action constraints

f64f7ed

yslpn dismissed their stale review via f64f7ed August 6, 2026 21:08

yslpn self-assigned this Aug 6, 2026

cubic-dev-ai Bot reviewed Aug 6, 2026

View reviewed changes

Comment thread packages/to-json-schema/src/converters/convertAction/convertAction.ts Outdated

yslpn added 2 commits August 6, 2026 23:22

Revert "fix(to-json-schema): preserve composed action constraints"

112a73d

This reverts commit f64f7ed.

Revert "feat: add code points actions support for to-json-schema"

0cb49aa

This reverts commit ee49c4d.

yslpn approved these changes Aug 6, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

tats-u commented Oct 20, 2024 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

fabian-hiller commented Oct 20, 2024

Uh oh!

tats-u commented Oct 22, 2024

Uh oh!

fabian-hiller commented Oct 28, 2024

Uh oh!

tats-u commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabian-hiller commented Oct 28, 2024

Uh oh!

vercel Bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tats-u commented Apr 29, 2025

Uh oh!

tats-u commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabian-hiller commented Jun 17, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yslpn commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yslpn commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tats-u commented Oct 20, 2024 •

edited by coderabbitai Bot

Loading

tats-u commented Oct 28, 2024 •

edited

Loading

vercel Bot commented Apr 29, 2025 •

edited

Loading

tats-u commented Apr 29, 2025 •

edited

Loading

pkg-pr-new Bot commented Jun 17, 2025 •

edited

Loading

yslpn commented Jul 26, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

yslpn commented Aug 6, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading