🐛 fix: replace broken engineerd/setup-kind action in e2e workflow

[mikeshng]

Summary

fix: replace broken engineerd/setup-kind action in e2e workflow

Related issue(s)

#122

#123

Summary by CodeRabbit

• Chores
  • Streamlined the end-to-end test environment setup.
  • Automated test runs now use a simpler cluster creation step, which should help keep CI runs more consistent.

[mikeshng]

/assign @tesshuflower @dhaiducek @rokej

[coderabbitai]

Walkthrough

The e2e GitHub Actions workflow's kind cluster setup step is changed from using the engineerd/setup-kind action to an inline kind create cluster --wait 300s command, removing the action-based version configuration.

Changes

E2E Workflow Kind Setup

Layer / File(s)	Summary
Kind cluster creation step .github/workflows/e2e.yml	Replaced the engineerd/setup-kind@v0.6.2 action with an inline run: kind create cluster --wait 300s command, removing the explicit kind version and log export settings.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Related PRs: None found.

Suggested labels: ci, e2e

Suggested reviewers: None found.

🤖 A poem for the change:

A rabbit hopped into the CI stream,
Swapped an action for a simpler dream,
"kind create cluster," it typed with care,
Waiting three hundred seconds, breathing air,
One less dependency, cleaner scheme.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: replacing the broken setup-kind action in the e2e workflow.
Description check	✅ Passed	The description follows the template structure with a summary and related links, and it is mostly complete.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[dhaiducek]

LGTM!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mikeshng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

🧹 Nitpick comments (1)

.github/workflows/e2e.yml (1)

34-35: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Pin the kind version/node image for reproducibility.

The previous engineerd/setup-kind action configured an explicit kind version; the inline command drops any version pinning. Another workflow in this repo (test.yml) explicitly pins version: v0.27.0 and node_image: kindest/node:v1.31.9 when creating its kind cluster. Leaving this unpinned risks inconsistent Kubernetes versions between e2e runs and drift relative to the other workflow's tested configuration.

♻️ Suggested fix: pin kind/node versions

-      - name: Setup kind
-        run: kind create cluster --wait 300s
+      - name: Setup kind
+        run: kind create cluster --image kindest/node:v1.31.9 --wait 300s

As per the relevant code snippet from .github/workflows/test.yml (lines 140-147), the sibling workflow pins both the kind version and the node image when creating its cluster.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/e2e.yml around lines 34 - 35, The Setup kind step in the
e2e workflow is missing explicit version pinning, unlike the kind setup used in
test.yml. Update the kind create cluster invocation in the e2e workflow to match
the pinned configuration by specifying the same kind version and node image used
for reproducible clusters. Keep the change localized to the Setup kind step so
the cluster creation behavior stays aligned with the existing tested setup.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/e2e.yml:
- Around line 34-35: The Setup kind step in the e2e workflow is missing explicit
version pinning, unlike the kind setup used in test.yml. Update the kind create
cluster invocation in the e2e workflow to match the pinned configuration by
specifying the same kind version and node image used for reproducible clusters.
Keep the change localized to the Setup kind step so the cluster creation
behavior stays aligned with the existing tested setup.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4dadd93a-a3aa-40db-8fac-de6385d76044

📥 Commits

Reviewing files that changed from the base of the PR and between f5844b9 and f0132e8.

📒 Files selected for processing (1)

• .github/workflows/e2e.yml

[tesshuflower]

Not strictly necessary, but in other places we specify the K8S version to be used by kind, to preserve the version being tested against (v0.31.0 in this case):

See: open-cluster-management-io/ocm@2f731e3#diff-3e103440521ada06efd263ae09b259e5507e4b8f7408308dc227621ad9efa31e

Without this you just get whatever is the default in the kind version that is packaged in the gh actions runner img.