Skip to content

🌱 chore: upgrade to go 1.26#385

Merged
openshift-merge-bot[bot] merged 1 commit into
open-cluster-management-io:mainfrom
tesshuflower:ocm-1555-golang-1.26
Jun 17, 2026
Merged

🌱 chore: upgrade to go 1.26#385
openshift-merge-bot[bot] merged 1 commit into
open-cluster-management-io:mainfrom
tesshuflower:ocm-1555-golang-1.26

Conversation

@tesshuflower

@tesshuflower tesshuflower commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Upgrades Go version from 1.25 to 1.26.

Changes:

  • go.mod — go directive updated to 1.26.0
  • .github/workflows/go-presubmit.yml — GO_VERSION updated to 1.26
  • .github/workflows/go-postsubmit.yml — GO_VERSION updated to 1.26
  • .github/workflows/go-release.yml — GO_VERSION updated to 1.26
  • .github/workflows/cloudevents-integration.yml — GO_VERSION updated to 1.26 (was incorrectly pinned to 1.24)
  • build/Dockerfile.example — base image updated to golang:1.26-bookworm

Relates to: open-cluster-management-io/ocm#1555

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain version to 1.26 across build configurations and CI/CD workflows.

Updates go.mod, GitHub Actions workflows, and Dockerfile.example to use Go 1.26.

Relates to: open-cluster-management-io/ocm#1555

Signed-off-by: Tesshu Flower <tflower@redhat.com>
@openshift-ci openshift-ci Bot requested review from deads2k and elgnay June 12, 2026 13:18
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 42307cf6-7c1f-4fee-9d0e-3dbe735726f5

📥 Commits

Reviewing files that changed from the base of the PR and between 5017f37 and 6991cde.

📒 Files selected for processing (6)
  • .github/workflows/cloudevents-integration.yml
  • .github/workflows/go-postsubmit.yml
  • .github/workflows/go-presubmit.yml
  • .github/workflows/go-release.yml
  • build/Dockerfile.example
  • go.mod

Walkthrough

Go toolchain version updated to 1.26 across the project: module definition in go.mod, container builder image in build/Dockerfile.example, and all four GitHub Actions workflows that define GO_VERSION for CI/CD jobs.

Changes

Go Toolchain Upgrade

Layer / File(s) Summary
Go toolchain upgrade to 1.26
go.mod, build/Dockerfile.example, .github/workflows/cloudevents-integration.yml, .github/workflows/go-postsubmit.yml, .github/workflows/go-presubmit.yml, .github/workflows/go-release.yml
Go version directive in go.mod updated to 1.26.0, Docker builder image updated to golang:1.26-bookworm, and GO_VERSION environment variable updated across all GitHub Actions workflows.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly Related PRs

  • open-cluster-management-io/addon-framework#320: Both PRs directly adjust the Go toolchain version in go.mod and the GitHub Actions GO_VERSION env for the same workflow files (plus builder image Go base in build/Dockerfile.example), so the changes overlap at the version-setting code level.

Suggested Labels

ok-to-test

Suggested Reviewers

  • zhujian7
  • qiujian16
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: upgrading Go from version 1.25 to 1.26 across multiple workflow files and configuration files.
Description check ✅ Passed The description provides a clear summary and comprehensive list of all changed files with specific details about what was updated. While it doesn't follow the exact template structure with distinct 'Summary' and 'Related issue(s)' sections, the content is well-organized and complete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tesshuflower tesshuflower changed the title chore: upgrade to go 1.26 🌱 chore: upgrade to go 1.26 Jun 12, 2026
@tesshuflower

Copy link
Copy Markdown
Contributor Author

@qiujian16 or @jnpacker could I get a review on this one?

@qiujian16

Copy link
Copy Markdown
Member

/approve
/lgtm

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, qiujian16, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 0e55300 into open-cluster-management-io:main Jun 17, 2026
15 of 16 checks passed
@tesshuflower tesshuflower deleted the ocm-1555-golang-1.26 branch June 18, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants