ACM-22604 Initial clusterRoleBindings feature

[fxiang1]

https://issues.redhat.com/browse/ACM-22604

• Add new field clusterRoleBindings (plural) optional
• Kept old field clusterRoleBinding (singular) optional for backwards compatibility
• If both fields exist clusterRoleBindings will override clusterRoleBinding

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.61%. Comparing base (1678382) to head (4a5b60d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   68.24%   69.61%   +1.37%     
==========================================
  Files           2        2              
  Lines         381      418      +37     
==========================================
+ Hits          260      291      +31     
- Misses        107      111       +4     
- Partials       14       16       +2     

Flag	Coverage Δ
unit	69.61% <ø> (+1.37%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fxiang1]

/uncc @xiangjingli

[fxiang1]

@mikeshng Please review when you have some cycles. Thanks!

[mikeshng]

@mikeshng Please review when you have some cycles. Thanks!

Thanks. Will do! It still have the do not merge hold tag that's why I didn't start reviewing it yet. Removing it.

/unhold

[mikeshng]

This if block is confusing and I think unnecessary. To deal with the spec crbs and backward compatible spec crb, we should add the handling spec crbs logic first. Like:

If crbs exists then do crbs stuffs, so now the return var "clusterRoleBindings" should not be empty anymore.

Only if return var "clusterRoleBindings" is empty and spec crb exist then do crb stuffs

[fxiang1]

Ok how about the latest change? I tried a different AI prompt.

[mikeshng]

/approve

/lgtm

I still prefer having the plural block to come first but it's not a big deal.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [fxiang1,mikeshng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment