Skip to content

Fix performance issue in large scale envs - #69

Merged
openshift-merge-bot[bot] merged 1 commit into
open-cluster-management-io:mainfrom
fxiang1:feng-perf
Sep 26, 2025
Merged

Fix performance issue in large scale envs#69
openshift-merge-bot[bot] merged 1 commit into
open-cluster-management-io:mainfrom
fxiang1:feng-perf

Conversation

@fxiang1

@fxiang1 fxiang1 commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

https://issues.redhat.com/browse/ACM-24032

  • Remove Owns function call as this was caching too many ManifestWork events

Now the memory usage is
image

Probably due to the ManageClusterAddon watch that was added. There is ~21391 ManageClusterAddons on this cluster.

Signed-off-by: fxiang1 <fxiang@redhat.com>
@openshift-ci

openshift-ci Bot commented Sep 25, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Sep 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.09%. Comparing base (8be7731) to head (f29bbbc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   66.14%   66.09%   -0.05%     
==========================================
  Files           2        2              
  Lines         700      699       -1     
==========================================
- Hits          463      462       -1     
  Misses        215      215              
  Partials       22       22              
Flag Coverage Δ
unit 66.09% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiangjingli

Copy link
Copy Markdown
Collaborator

/lgtm

@fxiang1

fxiang1 commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator Author

/hold

@fxiang1

fxiang1 commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator Author

/unhold

@openshift-merge-bot
openshift-merge-bot Bot merged commit 5b01809 into open-cluster-management-io:main Sep 26, 2025
8 checks passed
@fxiang1
fxiang1 deleted the feng-perf branch September 26, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants