Skip to content

Reduce ClusterPermission controller reconcile rate - #77

Merged
openshift-merge-bot[bot] merged 1 commit into
open-cluster-management-io:mainfrom
fxiang1:feng-controllerreconcile
Oct 27, 2025
Merged

Reduce ClusterPermission controller reconcile rate#77
openshift-merge-bot[bot] merged 1 commit into
open-cluster-management-io:mainfrom
fxiang1:feng-controllerreconcile

Conversation

@fxiang1

@fxiang1 fxiang1 commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

https://issues.redhat.com/browse/ACM-25572

  • Set the controller and informer cache sync rate to 10 hours
  • Adjusted the controller to only update the ManifestWork if the spec changed

Signed-off-by: fxiang1 <fxiang@redhat.com>
@fxiang1

fxiang1 commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator Author

/uncc @philipwu08

@openshift-ci
openshift-ci Bot removed the request for review from philipwu08 October 27, 2025 14:00
@codecov

codecov Bot commented Oct 27, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.71%. Comparing base (7692baa) to head (c70beb4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   60.28%   60.71%   +0.43%     
==========================================
  Files           3        3              
  Lines         924      756     -168     
==========================================
- Hits          557      459      -98     
+ Misses        337      266      -71     
- Partials       30       31       +1     
Flag Coverage Δ
unit 60.71% <ø> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikeshng mikeshng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

The resync period should be optionally exposed to pass in from an ENV or cmd param or something.The default is also a bit strange. Probably something like 12 hrs or 24 hrs better. But these are not important details.

@openshift-ci

openshift-ci Bot commented Oct 27, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit af5a756 into open-cluster-management-io:main Oct 27, 2025
8 checks passed
@fxiang1
fxiang1 deleted the feng-controllerreconcile branch October 27, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants