Skip to content

Add goverance.md for OCM incubation checks. - #205

Merged
openshift-merge-bot[bot] merged 1 commit into
open-cluster-management-io:mainfrom
xuezhaojun:add-goverance.md
Jul 17, 2025
Merged

Add goverance.md for OCM incubation checks.#205
openshift-merge-bot[bot] merged 1 commit into
open-cluster-management-io:mainfrom
xuezhaojun:add-goverance.md

Conversation

@xuezhaojun

@xuezhaojun xuezhaojun commented Jan 13, 2025

Copy link
Copy Markdown
Member

Fixes issue: #196

The sections: Decision making, CoC, Steering Committee/Members are new, others are copied from #72

@openshift-ci
openshift-ci Bot requested review from deads2k and qiujian16 January 13, 2025 07:29
@xuezhaojun xuezhaojun changed the title Add goverance.md for OCM incubation checks. WIP: Add goverance.md for OCM incubation checks. Jan 13, 2025
Comment thread GOVERANCE.md Outdated
@xuezhaojun xuezhaojun changed the title WIP: Add goverance.md for OCM incubation checks. Add goverance.md for OCM incubation checks. Jan 13, 2025
@xuezhaojun

Copy link
Copy Markdown
Member Author

/assign @qiujian16

@qiujian16

Copy link
Copy Markdown
Member

/assign @mikeshng

@mikeshng mikeshng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time and writing this! I am ok with everything that is stated here. Just some nits.

Comment thread GOVERANCE.md Outdated
Comment thread GOVERANCE.md Outdated
Comment thread GOVERANCE.md Outdated
Comment thread GOVERANCE.md Outdated
Comment thread GOVERANCE.md Outdated

# Project Governance

The project consists of the following Subprojects:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we define subprojects here? Based on the CNCF incubation checkbox:

If the project has subprojects: subproject leadership, contribution, maturity status documented, including add/remove process.

So, Registration, Work, Scheduling, Operator might not be the Subprojects, and we should list addon-framework, sdk-go and clusteradm here.

What do you think?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And refer to the example in https://github.com/cncf/toc/blob/main/projects/cubefs/cubefs-graduation-dd.md?plain=1#L213, the below governance template should be added to each subproject:

Governance

  • < subproject-name > is a sub-project of the OCM main project, complying with the rules of OCM main projects.
  • < subproject-name > does not have independent leadership, adopting the same leadership strategy as the OCM main project.
  • Contributions to < subproject-name > are equivalent to contributions to the main project and can be used as a basis for community role promotion.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question, we should discuss this in the incubation meeting.

Comment thread GOVERANCE.md Outdated
Comment thread GOVERNANCE.md Outdated

## Subproject Categories

### Core Subprojects

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiujian16 @haoqing0110

Seperate the subprojects into Core and Extensions and Addons

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if Core Subprojects is a commonly used term. Refer to the checkbox, my understanding is we just need to list Project (core) and Subprojects (Extensions and Addons).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, project (core) seems better to me also.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, updated to Core and SubProject, please take another look, thanks!

Comment thread GOVERNANCE.md Outdated
@xuezhaojun
xuezhaojun requested a review from haoqing0110 July 10, 2025 06:31
@xuezhaojun

Copy link
Copy Markdown
Member Author

@qiujian16 @haoqing0110 The doc updated, please take another look! Thanks!

Comment thread GOVERNANCE.md Outdated
Comment thread GOVERNANCE.md Outdated
- [SDK](https://github.com/open-cluster-management-io/sdk-go) - Go SDK for OCM

**Core Subproject Requirements:**
- Maintained by OCM core maintainers and approved contributors

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what is the difference between core maintainers and approved contributors.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core maintainers are owners who only need /lgtm
approved contributors need /lgtm and /approve to merge a PR.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does approved contributors mean? what is the difference from other contributors?

@xuezhaojun xuezhaojun Jul 11, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the confusing point... the approved contributors is removed now.

Comment thread GOVERNANCE.md Outdated
**Core Subproject Requirements:**
- Maintained by OCM core maintainers and approved contributors
- Follow strict release cycles and version compatibility guarantees
- Adhere to high code quality standards and comprehensive testing

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this as a requirement? I think provide long-term support and stability commitments is good enough.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Comment thread GOVERNANCE.md Outdated
- Release cycles, versioning, and quality standards are determined by project maintainers
- Project maintainers are responsible for maintenance, security responses, and community management

## Core Subproject Governance

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Core Subproject Governance
## Core Project Governance

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment thread GOVERNANCE.md Outdated
## Core Subproject Governance

All active Maintainers of each Core Subproject, as defined in the Contributor Ladder, are
members of that subproject's Maintainer Committee, which governs that subproject. The

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subproject's Maintainer Committee is confusing. We only need to state the responsibility of the maintainer.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure,removed all maintainer commitee.

Comment thread GOVERNANCE.md Outdated

- Ensuring that the subproject creates and publishes regular, stable releases following OCM release cycles;
- Maintaining version compatibility guarantees and migration paths;
- Holding regular, subproject-wide discussions on issues and planning;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we need a steering committee for each sub project. A steering committee for the whole project is fine.

The responsibility of here seems mainly for steering committee.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, remove the steering committee part of subproject.

@xuezhaojun
xuezhaojun requested a review from qiujian16 July 11, 2025 00:28
Signed-off-by: xuezhaojun <zxue@redhat.com>
@qiujian16

Copy link
Copy Markdown
Member

/approve

looks good in the overall shape. We can iterate based on this.

/assign @mikeshng

@mikeshng mikeshng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Thanks for this one!

@openshift-ci openshift-ci Bot added the lgtm label Jul 17, 2025
@openshift-ci

openshift-ci Bot commented Jul 17, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 251aa14 into open-cluster-management-io:main Jul 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants