ManifestWorkReplicaSet Rollout Plugin - #160
Merged
openshift-merge-bot[bot] merged 1 commit intoDec 3, 2025
Merged
Conversation
youngbupark
commented
Oct 28, 2025
youngbupark
commented
Contributor
- This is the initial draft for supporting rollout plugin in ManifestWorkReplicaSet Work Controller
- Note: rollback will be added when we propose MWRS automatic rollback enhancement.
youngbupark
commented
Oct 28, 2025
| The following service defines the contract between Work Controller and the plugin. Each call must be idempotent, stateless, and time-bounded (≤30 s) to ensure consistent controller reconciliation. Plugin server must implement the following APIs. The helpers to implement server and clients will be implemented in [ocm/sdk-go](https://github.com/open-cluster-management-io/sdk-go) repository. | ||
|
|
||
| ```proto | ||
| // RolloutPluginService is the service for the rollout plugin. |
Contributor
Author
There was a problem hiding this comment.
Here is the initial commit of gRPC server proto - open-cluster-management-io/sdk-go#154
Note: The implementation can change as we develop.
youngbupark
commented
Oct 28, 2025
youngbupark
changed the title
youngbupark
marked this pull request as ready for review
October 29, 2025 02:00
qiujian16
reviewed
Oct 29, 2025
haoqing0110
reviewed
Oct 30, 2025
annelaucg
reviewed
Oct 31, 2025
youngbupark
commented
Nov 18, 2025
youngbupark
commented
Nov 18, 2025
youngbupark
commented
Nov 18, 2025
qiujian16
reviewed
Nov 18, 2025
| # optional. secretRef is the reference for ca | ||
| secretRef: | ||
| name: my-rollout-ca | ||
| namespace: default |
Member
There was a problem hiding this comment.
namespace might not be needed. The secret has to be put in the open-cluster-management-hub ns.
annelaucg
reviewed
Nov 19, 2025
annelaucg
reviewed
Nov 19, 2025
haoqing0110
reviewed
Nov 20, 2025
youngbupark
commented
Nov 28, 2025
youngbupark
commented
Nov 29, 2025
youngbupark
force-pushed
the
add-plugin
branch
3 times, most recently
from
December 2, 2025 03:44
95aca1a to
7edf2ba
Compare
youngbupark
commented
Dec 2, 2025
| - "@qiujian16" | ||
| - "@haoqing0110" | ||
| approvers: | ||
| - "@qiujian16" |
Contributor
Author
There was a problem hiding this comment.
@qiujian16 @haoqing0110 I have added your names here.
Member
|
@youngbupark Thanks for the contribution! The proposal looks good to me. Just one minor nit: I noticed a few 'TBD' and 'WIP' markers left in the text. You might want to clean those up. |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, youngbupark The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Young Bu Park <youngbu.park@salesforce.com>
youngbupark
force-pushed
the
add-plugin
branch
from
December 3, 2025 02:54
7edf2ba to
c85d923
Compare
Member
|
/lgtm |
openshift-merge-bot
Bot
merged commit Dec 3, 2025
a14f0f3
into
open-cluster-management-io:main
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.