clusterset delete policy - #53
Conversation
Signed-off-by: ldpliu <daliu@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ldpliu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign @qiujian16 @elgnay |
qiujian16
left a comment
qiujian16
left a comment
There was a problem hiding this comment.
I think we might consider whether a clusterset owns a cluster, instead of a deletion policy
| The proposed work enhances the managedClusterSet API to handle managedClusterSet Delete policy. | ||
|
|
||
| ## Motivation | ||
| Currently, when we add a cluster to a clusterset, we will add a label `cluster.open-cluster-management.io/clusterset:<Clusterset Name>` to the cluster. But when the clusterset is deleted, this label will not be removed. |
There was a problem hiding this comment.
please clarify why this is a problem
There was a problem hiding this comment.
this need more clarification on use cases.
|
|
||
| ## Proposal Detail | ||
| Actually, we always use clusterset as a group of clusters. So when deleting a clusterset, there are some options for the delete policy. | ||
| 1. When clusterset deleted, delete the clusterset labels in managedClusters. |
There was a problem hiding this comment.
I still think this is an unnatural behavior to remove a thing not managed by it.
|
|
||
| ``` | ||
| ### Details | ||
| Notes: the `DeletePolicy` only works for the `ClusterSelector.SelectorType` is `LegacyClusterSetLabel`. It means the clusterset uses the label `cluster.open-cluster-management.io/clusterset:<Clusterset Name>` to select target clusters. So In the doc, we only cover the clusterset which `ClusterSelector.SelectorType` is `LegacyClusterSetLabel` |
|
This issue/PR is marked stale and will be closed in 30 days unless there is new activity. |
4 participants
Signed-off-by: ldpliu daliu@redhat.com