Add bootstrap from capi - #482
Conversation
Signed-off-by: Jian Qiu <jqiu@redhat.com>
✅ Deploy Preview for open-cluster-management ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @mikeshng |
| {{% /tab %}} | ||
| {{< /tabpane >}} | ||
|
|
||
| ### Bootstrap a cluster provisioned by Cluster-API |
There was a problem hiding this comment.
The header is kind of confusing. This new section covers auto-register(?) which doesn't require any manual bootstrapping of the klusterlet. Maybe we should be moving the new content to a dedicated "Auto register" header instead.
Does this auto register still need clusteradm to run accept? If it doesn't, maybe move the new header to above "Install clusteradm CLI tool". If it does require clusteradm, then move the new header below "Install clusteradm CLI tool" but above "Bootstrap a klusterlet".
I am thinking the new header should be Auto-register a cluster provisioned by Cluster API then the rest of your content follows (which looks fine to me). Thanks.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This issue/PR is marked stale and will be closed in 30 days unless there is new activity. |
4 participants
No description provided.