Skip to content

📖 Fix errors for manifestwork condition rules - #499

Merged
openshift-merge-bot[bot] merged 2 commits into
open-cluster-management-io:mainfrom
zhujian7:fix/job-manualselector-immutable
Jul 18, 2025
Merged

📖 Fix errors for manifestwork condition rules#499
openshift-merge-bot[bot] merged 2 commits into
open-cluster-management-io:mainfrom
zhujian7:fix/job-manualselector-immutable

Conversation

@zhujian7

Copy link
Copy Markdown
Member

No description provided.

zhujian7 added 2 commits July 18, 2025 16:14
…ble field error

Signed-off-by: zhujian <jiazhu@redhat.com>
…r API spec

Signed-off-by: zhujian <jiazhu@redhat.com>
@netlify

netlify Bot commented Jul 18, 2025

Copy link
Copy Markdown

Deploy Preview for open-cluster-management ready!

Name Link
🔨 Latest commit 9b99e25
🔍 Latest deploy log https://app.netlify.com/projects/open-cluster-management/deploys/687a06c28d593b00087bc0d8
😎 Deploy Preview https://deploy-preview-499--open-cluster-management.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zhujian7
zhujian7 marked this pull request as ready for review July 18, 2025 08:33
@openshift-ci
openshift-ci Bot requested review from mikeshng and mprahl July 18, 2025 08:33
).exists(
c, c.status == 'True'
)
- |

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix error:

Error from server (BadRequest): error when creating "cel.yaml": ManifestWork in version "v1" cannot be handled as a ManifestWork: strict decoding error: unknown field "spec.manifestConfigs[0].conditionRules[0].celExpressions[0].expression"

name: pi-calculation
namespace: default
spec:
manualSelector: true

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix error:

Failed to apply manifest: Job.batch "pi-calculation" is invalid:
          [spec.selector: Required value, spec.template.metadata.labels: Invalid value:
          map[string]string(nil): `selector` does not match template `labels`, spec.selector:
          Invalid value: "null": field is immutable

@zhujian7

Copy link
Copy Markdown
Member Author

/cc @qiujian16

@openshift-ci
openshift-ci Bot requested a review from qiujian16 July 18, 2025 08:34
@qiujian16

Copy link
Copy Markdown
Member

/approve
/lgtm

@openshift-ci

openshift-ci Bot commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 18703df into open-cluster-management-io:main Jul 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants