Add note to OCM v1.3.1 about Policy v0.19.0 - #560
Conversation
✅ Deploy Preview for open-cluster-management ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JustinKuli The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughRelease documentation for OCM v1.3.1 is updated with a new "Add-on Components" subsection listing the policy add-on stack (v0.19.0) and providing changelog links for each policy-related component. ChangesRelease Documentation Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| ### 🧩 Policy Components | ||
|
|
||
| Policy add-ons release on their own schedule, independent of OCM core. The current policy stack is **v0.19.0**: | ||
|
|
||
| - **config-policy-controller** v0.19.0 [changelog](https://github.com/open-cluster-management-io/config-policy-controller/releases/tag/v0.19.0) | ||
| - **governance-policy-framework-addon** v0.19.0 [changelog](https://github.com/open-cluster-management-io/governance-policy-framework-addon/releases/tag/v0.19.0) | ||
| - **governance-policy-propagator** v0.19.0 [changelog](https://github.com/open-cluster-management-io/governance-policy-propagator/releases/tag/v0.19.0) | ||
| - **governance-policy-addon-controller** v0.19.0 [changelog](https://github.com/open-cluster-management-io/governance-policy-addon-controller/releases/tag/v0.19.0) | ||
| - **policy-generator-plugin** v0.19.0 [changelog](https://github.com/open-cluster-management-io/policy-generator-plugin/releases/tag/v0.19.0) | ||
|
|
There was a problem hiding this comment.
We'll hopefully have more add-ons that could be added to the releases here. Since we're setting precedence, I propose making the header and note about release independence more generic and then creating a list with sub-bullets, version, and release date.
Are there any release notes we'd want to add to the list aside from changelogs? And I'm also not sure how we're going to handle versioning for the async clusteradm updates. Might need more input on that. I wonder if a v1.3.1-1 or even v1.3.1-1-policy tag might do it...
| ### 🧩 Policy Components | |
| Policy add-ons release on their own schedule, independent of OCM core. The current policy stack is **v0.19.0**: | |
| - **config-policy-controller** v0.19.0 [changelog](https://github.com/open-cluster-management-io/config-policy-controller/releases/tag/v0.19.0) | |
| - **governance-policy-framework-addon** v0.19.0 [changelog](https://github.com/open-cluster-management-io/governance-policy-framework-addon/releases/tag/v0.19.0) | |
| - **governance-policy-propagator** v0.19.0 [changelog](https://github.com/open-cluster-management-io/governance-policy-propagator/releases/tag/v0.19.0) | |
| - **governance-policy-addon-controller** v0.19.0 [changelog](https://github.com/open-cluster-management-io/governance-policy-addon-controller/releases/tag/v0.19.0) | |
| - **policy-generator-plugin** v0.19.0 [changelog](https://github.com/open-cluster-management-io/policy-generator-plugin/releases/tag/v0.19.0) | |
| ### 🧩 Add-on Components | |
| **NOTE:** Add-ons release independently from OCM core. | |
| - **Policy Add-on, `v0.19.0`, 03 Jun 2026** | |
| - **config-policy-controller** v0.19.0 [changelog](https://github.com/open-cluster-management-io/config-policy-controller/releases/tag/v0.19.0) | |
| - **governance-policy-framework-addon** v0.19.0 [changelog](https://github.com/open-cluster-management-io/governance-policy-framework-addon/releases/tag/v0.19.0) | |
| - **governance-policy-propagator** v0.19.0 [changelog](https://github.com/open-cluster-management-io/governance-policy-propagator/releases/tag/v0.19.0) | |
| - **governance-policy-addon-controller** v0.19.0 [changelog](https://github.com/open-cluster-management-io/governance-policy-addon-controller/releases/tag/v0.19.0) | |
| - **policy-generator-plugin** v0.19.0 [changelog](https://github.com/open-cluster-management-io/policy-generator-plugin/releases/tag/v0.19.0) | |
There was a problem hiding this comment.
I like the idea of making the section for all addons! Sounds like the pattern could be that addons add their releases under the latest OCM release they've been tested with? Ideally they don't get added to older releases, unless necessary.
Regarding the format, I'm not sure that nested bullets will always be rendered correctly, so personally I think the heading + bullets format that the highlights section of 1.3.0 used might be more consistent. Let me try that out, with some details of the new release.
Regarding the clusteradm update, I don't really have a preference. Adding an additional version field seems like a hassle or a point of confusion. But changing what is already in v1.3.1 is also confusing.
Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
23976fd to
50873f9
Compare
The rest of the docs don't seem to specify a version for the Policy addons, but it would be nice to add the newest release to the OCM release note, just for awareness.
Summary by CodeRabbit