Skip to content

Add directory recursion to Argo deployment script - #559

Merged
openshift-merge-bot[bot] merged 1 commit into
open-cluster-management-io:mainfrom
joshgav:patch-1
Jul 31, 2026
Merged

Add directory recursion to Argo deployment script#559
openshift-merge-bot[bot] merged 1 commit into
open-cluster-management-io:mainfrom
joshgav:patch-1

Conversation

@joshgav

@joshgav joshgav commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Without this the policies in subfolders of stable or community are not applied.

Summary by CodeRabbit

  • Deployment
    • Argo CD now automatically discovers application manifests within nested subdirectories under the configured source path.
    • Existing deployment behavior and configuration options remain unchanged.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cca976c4-dc4a-4fca-9f21-c8f8942eb79f

📥 Commits

Reviewing files that changed from the base of the PR and between d56ac2e and 7453099.

📒 Files selected for processing (1)
  • deploy/argoDeploy.sh

Walkthrough

The generated Argo CD Application manifest now sets spec.source.directory.recurse to true, enabling recursive sourcing of manifests under the configured Git path.

Changes

Argo CD source configuration

Layer / File(s) Summary
Enable recursive manifest sourcing
deploy/argoDeploy.sh
Adds spec.source.directory.recurse: true to the generated Argo CD Application manifest.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: gparvin, jan-law

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: enabling directory recursion in the Argo deployment script.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Without this the policies in subfolders of `stable` or `community` are not applied.

Signed-off-by: Josh Gavant <4421720+joshgav@users.noreply.github.com>

@jan-law jan-law left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan-law, joshgav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit d1ee81e into open-cluster-management-io:main Jul 31, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants