no appsub should be present

[ch-stark]

appsub is deprecated for > 2 years and should not be used anymore

Summary by CodeRabbit

• Bug Fixes
  • Removed the Failed status from the Subscription configuration to prevent it from being treated as an active failure state.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ch-stark
Once this PR has been reviewed and has the lgtm label, please assign dhaiducek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 317a5acf-e2e7-4354-9600-d0d68bb3daec

📥 Commits

Reviewing files that changed from the base of the PR and between 4c60de6 and 2d52909.

📒 Files selected for processing (1)

• policygenerator/policy-sets/stable/acm-hardening/input-subscriptions/policy-subscriptions.yaml

💤 Files with no reviewable changes (1)

• policygenerator/policy-sets/stable/acm-hardening/input-subscriptions/policy-subscriptions.yaml

---

Walkthrough

The stable ACM hardening Subscription manifest removes the status.phase: Failed field.

Changes

Cohort / File(s)	Summary
Subscription manifest policygenerator/policy-sets/stable/acm-hardening/input-subscriptions/policy-subscriptions.yaml	Removes the status.phase: Failed declaration from the Subscription manifest.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the primary objective of removing appsub from the policy collection.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}