Skip to content

馃尡 expose cert refresh duration for testing via env. #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Dec 5, 2025
Merged

馃尡 expose cert refresh duration for testing via env. #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion pkg/cloudevents/generic/options/cert/rotation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"crypto/tls"
"crypto/x509"
"fmt"
"os"
"reflect"
"sync"
"time"
Expand All @@ -26,9 +27,32 @@ type Connection interface {

type reloadFunc func(*tls.CertificateRequestInfo) (*tls.Certificate, error)

// CertCallbackRefreshDuration is exposed so that integration tests can crank up the reload speed.
// CertCallbackRefreshDuration controls how frequently certificate callbacks reload.
// Default is 5 minutes.
//
// NOTE: This can be overridden via the environment variable
//
// CERT_CALLBACK_REFRESH_DURATION **for testing only**.
// Do NOT rely on this environment variable in production.
var CertCallbackRefreshDuration = 5 * time.Minute

func init() {
// TEST-ONLY OVERRIDE:
// Allow integration tests to reduce reload intervals by setting
// CERT_CALLBACK_REFRESH_DURATION to a valid Go duration string (e.g., "10s").
//
// If the variable is not set or is invalid, the default (5m) is preserved.
if v := os.Getenv("CERT_CALLBACK_REFRESH_DURATION"); v != "" {
d, err := time.ParseDuration(v)
if err != nil {
// Optional: log or print a warning
klog.Warningf("invalid CERT_CALLBACK_REFRESH_DURATION (%q): %v, using default\n", v, err)
return
}
CertCallbackRefreshDuration = d
}
}

type clientCertRotating struct {
sync.RWMutex

Expand Down