🌱 remove mw local watch store

[skeeey]

Summary

remove mw local watch store since no component uses it

Related issue(s)

Fixes #

Summary by CodeRabbit

• Revert
  • Removed local in-process storage and related watch functionality.
  • Removed associated integration tests.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b9dedc57-6a01-4d69-a3f2-3366e9ffa2c7

📥 Commits

Reviewing files that changed from the base of the PR and between 3041045 and 234f8c6.

📒 Files selected for processing (2)

• pkg/cloudevents/clients/work/store/local.go
• test/integration/cloudevents/manifestworkclients_watch_test.go

💤 Files with no reviewable changes (2)

• test/integration/cloudevents/manifestworkclients_watch_test.go
• pkg/cloudevents/clients/work/store/local.go

---

Walkthrough

Removal of the local in-process ManifestWork watcher store implementation and its comprehensive integration test suite. This entails deletion of the SourceLocalWatcherStore type, its initialization, event processing methods, and associated watch functionality for ManifestWork objects.

Changes

Cohort / File(s)	Summary
Local Watcher Store Implementation pkg/cloudevents/clients/work/store/local.go	Deleted SourceLocalWatcherStore struct, ListLocalWorksFunc type, NewSourceLocalWatcherStore constructor, and all methods including Add, Update, Delete, HasInitiated, GetWatcher, processLoop, and key function. Removed internal cache management, event queue processing, and watcher orchestration logic (256 lines deleted).
Integration Tests test/integration/cloudevents/manifestworkclients_watch_test.go	Deleted entire integration test file covering ManifestWork client watch functionality, including CRUD operations, watch event validation (Added/Modified/Deleted), resync scenarios, and custom lister tests with multi-component orchestration (378 lines deleted).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

approved, lgtm

Suggested reviewers

• deads2k
• qiujian16

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description provides a summary of why the change was made, but lacks details about which components were evaluated and why the store is no longer needed.	Clarify which components previously used or could have used this store, and explain why it's now safe to remove without breaking changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the ManifestWork local watch store implementation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[skeeey]

/assign @qiujian16

[qiujian16]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, skeeey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [qiujian16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment