Skip to content

✨ AddOnTemplate v1beta1 - #231

Merged
openshift-merge-bot[bot] merged 1 commit into
open-cluster-management-io:mainfrom
mikeshng:addontemplate-beta
Jul 13, 2026
Merged

✨ AddOnTemplate v1beta1#231
openshift-merge-bot[bot] merged 1 commit into
open-cluster-management-io:mainfrom
mikeshng:addontemplate-beta

Conversation

@mikeshng

@mikeshng mikeshng commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

AddOnTemplate v1beta1

Related issue(s)

open-cluster-management-io/ocm#1616

Summary by CodeRabbit

  • Bug Fixes
    • Updated the Open Cluster Management API dependency to a newer version.
    • Added compatibility for the latest add-on client interface while preserving the existing unsupported behavior for add-on templates.

Signed-off-by: Mike Ng <ming@redhat.com>
@openshift-ci
openshift-ci Bot requested review from deads2k and qiujian16 July 10, 2026 13:37
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The addon API dependency is updated, and AddonClientWrapper adds the required AddOnTemplates() method with an unsupported-operation panic.

Changes

Addon template interface support

Layer / File(s) Summary
Update addon API dependency
go.mod
Updates open-cluster-management.io/api from v1.3.0 to a newer v1.3.1 prerelease commit.
Add AddOnTemplates wrapper method
pkg/cloudevents/clients/addon/v1beta1/client.go
Adds AddonClientWrapper.AddOnTemplates(), which panics because the feature is unsupported.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers: deads2k

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is concise and accurately summarizes the AddOnTemplate v1beta1 support change.
Description check ✅ Passed The description includes the required Summary and Related issue(s) sections, with a linked issue provided.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mikeshng

Copy link
Copy Markdown
Member Author

/hold

Working on this. Creating the PR to check the CI first.

@mikeshng mikeshng changed the title ✨ WIP - AddOnTemplate v1beta1 ✨ AddOnTemplate v1beta1 Jul 12, 2026
@mikeshng

Copy link
Copy Markdown
Member Author

/unhold

/assign @qiujian16

Thanks!

@qiujian16

Copy link
Copy Markdown
Member

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 13, 2026
@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit c812bc0 into open-cluster-management-io:main Jul 13, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants