docs: Add .NET 10 Console sample application#722
Conversation
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new .NET 10 Console sample application to the repository. This sample serves as a practical guide for developers, illustrating the integration and usage of the OpenFeature .NET SDK within a console environment. It specifically demonstrates how to configure and utilize the InMemoryProvider to evaluate various feature flag types, providing a clear example of how to retrieve and act upon different flag values. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new .NET console sample application to demonstrate the usage of OpenFeature with an in-memory provider. The changes are generally good, but I've found a few issues. There's a bug in the sample code where a feature flag is defined with one key but retrieved with another, causing it to always fall back to the default value. The documentation for the sample refers to .NET 10, which is a future version and could be confusing. The project file is also missing an explicit TargetFramework. Additionally, for consistency with other samples like AspNetCore, you might consider simplifying the directory structure from samples/Console/Samples.Console to samples/Console in a future PR.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 68 68
Lines 2952 2952
Branches 350 350
=======================================
Hits 2759 2759
Misses 135 135
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
There was a problem hiding this comment.
LGTM! I wonder if we can convert into a single app file @kylejuliandev
Happy to convert this sample to a single app file, or introduce a 3rd sample? |
Just convert! Let's keep it simple 😄 |
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
3 participants
This PR
Add simple Console sample application which utilises the InMemory provider and demonstrates how you can retrieve different types of Flag from a provider.
Related Issues
Notes
Follow-up Tasks
How to test