replace naive StallLoaderStage implementation - #4376
Open
trippjoe wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull request #1768 "added a 10 frame delay in the loader in between finishing the last opengl buffer upload and making the Level available to renderers"
the implementation outlined in the referenced pull request is rather naive and can be both too conservative on high end computers.
this pull request improves on this by using glFenceSync to determine when the gpu has finished instead of an arbitrary 10 frame delay.
in my testing on mac and windows i measured an order of magnitude decrease in the stall time. i measured the original fixed stall to be around ~150 ms and after this change i measured the stall to be ~30 ms.