Fix timezone handling for recurring events#178
Merged
muness merged 1 commit intoJun 3, 2025
Conversation
muness
approved these changes
May 30, 2025
muness
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix and the readability improvements!
Member
|
I apologize for the delay, just pushed in 1.10.1 |
This was referenced Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyRecurrenceDateAndTimezonefunction to handle timezone offsets correctlyProblem
When running in non-UTC timezones (e.g., JST UTC+9), recurring events scheduled after 15:00 would incorrectly display events from the previous day due to improper timezone handling in the recurrence calculation logic.
Solution
applyRecurrenceDateAndTimezoneto properly handle UTC recurrence dates and convert them to the correct timezone while preserving the original event timeprocessRecurringRulesto use UTC for rrule calculations and timezone-aware date comparisonTest plan