Skip to content

fix(ci): dispatch the resolver by filename, not display name - #33039

Merged
mohityadav766 merged 2 commits into
mainfrom
ci/fix-dispatch-target
Sep 9, 2026
Merged

mohityadav766 merged 2 commits into
mainfrom
ci/fix-dispatch-target

Conversation

@mohityadav766

Copy link
Copy Markdown
Member

Every backport from here fails at the handover — run 34329850382. plan passes (label authorised, release branches resolved), then both dispatch jobs fail.

Cause

They name a workflow that no longer exists. openmetadata-collate renamed Resolve an OpenMetadata backport conflictBackport a labeled OpenMetadata PR when it took over driving the whole backport rather than only conflicts. This side still asked for the old name.

That's my mistake, and the ordering advice I gave ("merge Collate first") couldn't have helped — the reference itself was wrong, not the sequence.

Fix

benc-uk/workflow-dispatch accepts a filename as well as a display name. A filename doesn't move when a workflow is renamed:

workflow: oss-backport-resolve.yaml

The underlying problem was that a dispatch by display name is a cross-repository reference with nothing checking it — no linter sees it, and it breaks silently on a rename in another repo. Confirmed oss-backport-resolve.yaml exists on openmetadata-collate@main.

🤖 Generated with Claude Code

Every backport from here fails at the handover. `plan` passes — the label
is authorised and the release branches resolve — then both dispatch jobs
fail, because they name a workflow that no longer exists:
openmetadata-collate renamed `Resolve an OpenMetadata backport conflict`
to `Backport a labeled OpenMetadata PR` when it took over driving the
whole backport rather than only conflicts.

A dispatch by display name is a cross-repository reference with nothing
checking it: no linter sees it, and it breaks silently on a rename in
another repo. `benc-uk/workflow-dispatch` also accepts a filename, which
does not move when the workflow is renamed, so use that instead.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added backend safe to test Add this label to run secure Github workflows on PRs labels Sep 9, 2026
@gitar-bot

gitar-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Fixes CI backport dispatch by referencing the workflow file (oss-backport-resolve.yaml) instead of its display name, which broke after the workflow was renamed in the upstream repository. This eliminates silent failures on cross-repository workflow renames. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit d54fd55c4c253dc49c41abceca654b832c383abe in Playwright run 34338556497, attempt 1.

✅ 556 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 55m 22s

⏱️ Max setup 4m 32s · max shard execution 18m 49s · max shard-job elapsed before upload 22m 26s · reporting 6s

🌐 235.77 requests/attempt · 2.82 app boots/UI scenario · 10.98% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 235.77 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.82 per UI scenario (1634 boots / 579 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
🟡 Shard chromium-01 140 0 1 0 0 0
✅ Shard chromium-02 129 0 0 0 0 0
✅ Shard chromium-03 129 0 0 0 0 0
✅ Shard data-asset-rules-01 65 0 0 0 0 0
✅ Shard domain-isolation-01 16 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0
🟡 1 flaky test(s) (passed on retry)
  • Pages/Entity.spec.tsTier Add, Update and Remove (shard chromium-01, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@mohityadav766
mohityadav766 merged commit e09460b into main Sep 9, 2026
39 of 40 checks passed
@mohityadav766
mohityadav766 deleted the ci/fix-dispatch-target branch September 9, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants