Skip to content

fix: update glossaries immutably in updateActiveGlossary - #33043

Closed
a-kash-singh wants to merge 4 commits into
open-metadata:mainfrom
a-kash-singh:fix/glossary-stale-display-name
Closed

a-kash-singh wants to merge 4 commits into
open-metadata:mainfrom
a-kash-singh:fix/glossary-stale-display-name

Conversation

@a-kash-singh

@a-kash-singh a-kash-singh commented Sep 9, 2026

Copy link
Copy Markdown

updateActiveGlossary mutated the glossaries array in place, preserving the array reference. GlossaryLeftPanel memoizes its menu items on that reference, so a displayName-only edit left the left panel showing the stale label while the rest of the UI updated correctly.

Fix mirrors the existing updateGlossary pattern: replace the element via map so a new array reference is produced and downstream memos recompute.

Fixes #32674

     2
     3	In-place mutation (`glossaries[index] = updatedGlossary`) preserved the array
     4	reference, so GlossaryLeftPanel's memoized menu items never recomputed after a
     5	displayName-only edit. Mirror the existing updateGlossary pattern by creating a
     6	new array reference via map so downstream memos observe the change.
     7
     8	Fixes open-metadata#32674
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gitar-bot

gitar-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Fixes stale glossary display names in the left panel by replacing in-place mutation with immutable array updates via map, mirroring the existing updateGlossary pattern so downstream memos recompute correctly. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@a-kash-singh

Copy link
Copy Markdown
Author

Closing in favour of #32738 which covers the same fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Detail Bug] Glossary: left panel shows stale glossary displayName after displayName-only edit

1 participant