fix: update glossaries immutably in updateActiveGlossary - #33043
a-kash-singh wants to merge 4 commits into
Conversation
2
3 In-place mutation (`glossaries[index] = updatedGlossary`) preserved the array
4 reference, so GlossaryLeftPanel's memoized menu items never recomputed after a
5 displayName-only edit. Mirror the existing updateGlossary pattern by creating a
6 new array reference via map so downstream memos observe the change.
7
8 Fixes open-metadata#32674
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review ✅ ApprovedFixes stale glossary display names in the left panel by replacing in-place mutation with immutable array updates via OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
|
Closing in favour of #32738 which covers the same fix. |
updateActiveGlossary mutated the glossaries array in place, preserving the array reference. GlossaryLeftPanel memoizes its menu items on that reference, so a displayName-only edit left the left panel showing the stale label while the rest of the UI updated correctly.
Fix mirrors the existing updateGlossary pattern: replace the element via map so a new array reference is produced and downstream memos recompute.
Fixes #32674