fix(lineage): route platform lineage settings through the lineage store [backport 1.13] - #33298
chirag-madlani wants to merge 1 commit into
Conversation
The /lineage settings modal used to write into a local useState in PlatformLineage, but the LineageProvider fetch effect reads lineageConfig from the shared Zustand useLineageStore — so changing upstream/downstream depth silently produced no network call. Wire the page to the store directly (matching CustomControls for entity lineage) so the save handler triggers a refetch. Backport of #33197 from main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
Code Review ✅ ApprovedFixes the lineage settings modal by routing OptionsDisplay: compact → Counting what did not apply, without listing it. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
|



Backport of #33197 to
1.13.Summary
On
/lineage, opening the settings modal and changing Upstream / Downstream Depth silently produced no network call — the graph did not refetch.Root cause:
PlatformLineage.tsxkeptlineageConfigin a localuseState. ButLineageProvider's fetch effect readslineageConfigfrom the shared ZustanduseLineageStoreand re-runsfetchPlatformLineagewhen it changes. Writing to local state left the store untouched, so the effect never fired.Fix:
PlatformLineage.tsxnow readslineageConfigandsetLineageConfigfromuseLineageStore(same pattern asCustomControls). Save → store write → provider effect →getPlatformLineage?upstreamDepth=…&downstreamDepth=…fires.Scope
Backport is narrower than the main PR — only the app-code + unit-test fix is included. The Playwright spec consolidation from #33197 is intentionally skipped because 1.13 uses
Mui-selectedclass assertions while main usesdata-selected, and the goal here is a minimal, low-risk backport.Test plan
openmetadata-ui/src/main/resources/ui/src/pages/PlatformLineage/PlatformLineage.test.tsx: newLineage Store Integrationdescribe (modal receives store'slineageConfig;onSavecalls store'ssetLineageConfig;onCanceldoes not).upstreamDepth=2&downstreamDepth=2, changed to4/4in the modal, saved, and confirmedGET /api/v1/lineage/getPlatformLineage?view=service&upstreamDepth=4&downstreamDepth=4&…fired and the graph re-rendered.Files changed
openmetadata-ui/src/main/resources/ui/src/pages/PlatformLineage/PlatformLineage.tsx— swap local state → storeopenmetadata-ui/src/main/resources/ui/src/pages/PlatformLineage/PlatformLineage.test.tsx— new store-integration tests🤖 Generated with Claude Code