Skip to content

Backport #33393 to 1.13: match column-level tests in the test case table filter - #33570

Open
manerow wants to merge 1 commit into
1.13from
backport/33393-to-1.13
Open

manerow wants to merge 1 commit into
1.13from
backport/33393-to-1.13

Conversation

@manerow

@manerow manerow commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Backport of the column-level part of #33393 (Fixes #33388) to 1.13.

Problem

An observability alert can be narrowed to "test cases of these tables". On 1.13 that filter compares the test case's entityFQN, which for a column-level test is <table>.<column>, not the table. So an alert scoped to a table never fires for the column tests on it (not null, unique, values in set), which are most of a real suite. Nothing reports the miss.

Why it happened

#27987 made alert filters match names exactly instead of by pattern. Before it, this filter pattern-matched the table name inside the test case's own full name, which starts with its table's full name, so column tests matched. #27987 switched it to an exact comparison with entityFQN, which for a column test also carries the column, so they stopped matching. #27987 was backported, so every release from 1.13.0 to 1.13.6 has this, and anyone upgrading from 1.12 silently lost these alerts.

What this PR changes

The filter reads the table from the test case's entityLink, which is how search and permission checks already find it. That is one method in AlertsRuleEvaluator.

Not in this PR

#33393 also fixed how the test case and data contract filters handle comments (#31330, #33389). Those fixes build on #30571, which makes every scoping filter look at what a comment is about. #30571 is not on 1.13: here, all scoping filters let comment events through on purpose. Changing only these two would make them behave differently from the rest, so they are left as they are. For the same reason, the integration test that expects an event that is not a test case to pass the filter is unchanged. The 2.0 backport, which has #30571, takes all three fixes: #33569.

What users will notice

Alerts that use the table filter start receiving column-level test events again, as they did on 1.12.

How it was tested

RetriggerConfidence Score: 5/5

The PR appears safe to merge and restores the intended table-filter behavior without changing unrelated alert semantics.

Summary

This backport corrects table-scoped alert evaluation for column-level test cases by deriving the parent table FQN from the test case’s entity link rather than its column-qualified entityFQN.

  • Preserves exact matching and rejects similarly prefixed table names.
  • Adds focused coverage for table-level and column-level test cases.
  • Updates integration fixtures to reflect valid persisted test-case payloads.

Reviews (1) · Last reviewed commit: "Backport #33393 to 1.13: match column-le..."

@manerow
manerow requested a review from a team as a code owner September 18, 2026 09:12
@manerow manerow added safe to test Add this label to run secure Github workflows on PRs backend skip-pr-checks Bypass PR metadata validation check labels Sep 18, 2026
@gitar-bot

gitar-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk

Backport to 1.13 fixes column-level test cases matching in table-scoped alerts by reading the table from the test case's entityLink instead of comparing the full entityFQN. This restores alert firing for column tests (not null, unique, values in set) that was broken by #27987. No issues found.

Review coverage

Rules No rules evaluated

Functional validation Not enabled · Set up

Auto-approval Not enabled · Set up

Options

Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant