v6.0.x: Use compiler basename in ltmain_flang_darwin patch#13804
Open
billsacks wants to merge 1 commit intoopen-mpi:v6.0.xfrom
Open
v6.0.x: Use compiler basename in ltmain_flang_darwin patch#13804billsacks wants to merge 1 commit intoopen-mpi:v6.0.xfrom
billsacks wants to merge 1 commit intoopen-mpi:v6.0.xfrom
Conversation
Checking $CC directly fails if the compiler is given with a full path (e.g., in a Spack-based build). This change fixes the check of the compiler to use the basename, as is done in a few other places. Signed-off-by: Bill Sacks <sacks@ucar.edu> (cherry picked from commit fc7fa11)
Contributor
Author
|
As with the versions on v5.0.x and main: Credit goes to @mcmehrtens for pointing out the problem and suggested fix in https://groups.google.com/a/lists.open-mpi.org/g/users/c/4mIxq9op75k |
Contributor
Author
|
@ggouaillardet - since I think you put in place the original fix in #13142 , are you able to comment on why the patch on main (which is the same as the one here, in the v6.0.x branch) differs from the patch on the v5.0.x branch? (i.e., why did your added patch in #13162 differ from your added patch in #13142?) I'm concerned that the patch on main and here seems like it won't apply cleanly to libtool's ltmain.sh. But I could easily be missing something - I have very little knowledge of this area. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking $CC directly fails if the compiler is given with a full path (e.g., in a Spack-based build). This change fixes the check of the compiler to use the basename, as is done in a few other places.
(cherry picked from commit fc7fa11)
Resolves #13770 for the v6.0.x branch. (See also #13771 for the corresponding PR to main: this is a back-port of that PR.)
I haven't tested this with the v6.0.x branch or with the main branch; I did test the conceptually equivalent changes in the v5.0.x branch (see #13772 ). As I noted in #13771 , I am concerned that the patch here may not apply cleanly to libtool's ltmain.sh, and this may need to be changed to the version on the v5.0.x branch.