Merged
Conversation
Contributor
Author
|
looks like arm failed with a timeout trying to get the oqs certificate, force pushed to do a rebuild |
Contributor
Author
|
looks like the arm build has hung in the middle of building openssl, so seems there are issues with the github arm runners at the moment |
Member
|
Thanks for this work, David! |
This has some caveats to be aware of 1. No idea if it would work on apple or windows OS as they are not linux and would also need an X Server 2. Image is fixed to Ubuntu 22.04. Can't update the base image it won't work. 3. Tested on a Ubuntu 24.04 VM and Raspian Bookworm 64bit on a raspberry pi. In general running GUIs from containers is complex requiring various other components such as dbus to be running. In the case here it manages to work with an environment variable hack, but moving to 24.04 introduced a new issue with dbus. KDE apps may also have issues. Even X Can have issues like the shared memory extension. There are interesting tools such as X11Docker which try to provide easier solutions but on the whole trying to run gui applications from a container can be fragile. Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com>
Contributor
Author
|
the github actions issue with arm appears to be resolved and the arm build has now worked |
SWilson4
reviewed
May 13, 2025
SWilson4
approved these changes
May 13, 2025
bhess
reviewed
May 13, 2025
Member
|
Merging as all outstanding comments have been resolved. Thanks @davidkel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has some caveats to be aware of
In general running GUIs from containers is complex requiring various other components such as dbus to be running. In the case here it manages to work with an environment variable hack, but moving to 24.04 introduced a new issue with dbus. KDE apps may also have issues. Even X Can have issues like the shared memory extension. There are interesting tools such as X11Docker which try to provide easier solutions but on the whole trying to run gui applications from a container can be fragile.