Fix import parameters based on 'OSSL_KEYMGMT_SELECT_KEYPAIR'#754
Merged
RodriM11 merged 4 commits intoopen-quantum-safe:mainfrom Feb 24, 2026
Merged
Fix import parameters based on 'OSSL_KEYMGMT_SELECT_KEYPAIR'#754RodriM11 merged 4 commits intoopen-quantum-safe:mainfrom
RodriM11 merged 4 commits intoopen-quantum-safe:mainfrom
Conversation
Signed-off-by: RodriM11 <62776780+RodriM11@users.noreply.github.com>
Signed-off-by: RodriM11 <62776780+RodriM11@users.noreply.github.com>
Signed-off-by: RodriM11 <62776780+RodriM11@users.noreply.github.com>
Member
Author
|
Yes @baentsch sorry! I (wrongly) assumed that |
ashman-p
previously approved these changes
Feb 23, 2026
Signed-off-by: RodriM11 <62776780+RodriM11@users.noreply.github.com>
Member
Author
|
@baentsch a test has now been added! |
Member
Author
|
Merged into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the parameter selection for import key material from
OSSL_KEYMGMT_SELECT_ALL_PARAMETERStoOSSL_KEYMGMT_SELECT_KEYPAIR. Fixes #745.The bug was making invalid an import with parameter selection
OSSL_KEYMGMT_SELECT_KEYPAIR, even when elements pertaining to the key pair were imported.This means a behavior change for users employing a selection for key material import with value
& OSSL_KEYMGMT_SELECT_KEYPAIR = 0. Furthermore, the procedureoqsx_key_fromdatais enforcing the parameterinclude_private.