app: adopt ord-app UI styling (#171 rebased + cleaned up) - #177
Closed
skearnes wants to merge 3 commits into
Closed
Conversation
…heme, and fonts from ord-app.
- 1 rem → 1rem (invalid CSS, browser was ignoring it). - 900vh → 90vh (likely a slip; matches original intent of a viewport-bound max height on the search options sidebar). - Drop $lightgrey / $medgrey / $linkblue / $hoverblue, which the PR re-defined to duplicate values of $color-background-main / $gray-6 / $color-primary / $color-text-hover. Update remaining references so the codebase uses one naming scheme. $darkgrey stays — it has no direct equivalent in the new palette. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
#a0a0a0 had no equivalent in the new palette. Renamed to $color-shadow-2 (parallel to $color-shadow-1) so every style variable follows the new $color-* / $gray-* / $dark-* naming. Color values are unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the UI updates from #171 (by @alli-linhart at Lucy-Family-Institute) onto current main and irons out a few rough spots so it can land here.
Summary
$color-*/$gray-*/$dark-*style variables invars.sass.1 rem→1remand900vh→90vhinSearchOptions.vue.$lightgrey/$medgrey/$linkblue/$hoverbluealiases (the PR redefined them to mirror new$color-*values) and renames$darkgrey→$color-shadow-2so the codebase uses a single naming scheme.vue.config.jsproxy tweak — that file was removed in the Vite migration (Migrate SPA to Vite; adopt Prettier #176), andvite.config.jsdeliberately uses127.0.0.1:5000(see in-file comment).The proxy change aside, every other style/UI change from #171 is preserved. Color values are unchanged across the rename pass.
Test plan
npm run format:check(passes locally)npm run lint(passes; only pre-existing warnings)npm run build(passes locally)