Skip to content

Reformat view.py to 88 chars to fix red check_python on main - #194

Merged
skearnes merged 1 commit into
mainfrom
cleanup/format-view-py
Jun 21, 2026
Merged

Reformat view.py to 88 chars to fix red check_python on main#194
skearnes merged 1 commit into
mainfrom
cleanup/format-view-py

Conversation

@skearnes

@skearnes skearnes commented Jun 21, 2026

Copy link
Copy Markdown
Member

What

main's check_python job is currently red. #187 added two HTTPException calls in view.py (and one line in view_test.py) wider than 88 chars; it merged after #188 lowered the ruff line length to 88, without rebasing, so the ruff format --check ord_interface step has been failing on main ever since. #186 didn't touch these files.

This is a pure ruff format reflow of those lines — no behavior change. It unblocks CI on main (and on the other open cleanup PRs, whose check_python inherits the same tree).

Verification

  • ruff format --check ord_interface clean.
  • ruff check clean.

🤖 Generated with Claude Code

Greptile Summary

This is a pure ruff format reflow to bring two HTTPException calls in view.py and one test call in view_test.py within the 88-character line limit introduced in #188. There are no logic or behavior changes.

  • view.py: Two HTTPException constructions (404 and 500) split across multiple lines to satisfy the 88-char limit.
  • view_test.py: One test_client.get(...) call reformatted identically for the same reason.

Confidence Score: 5/5

Safe to merge — exclusively whitespace/line-wrap reformatting with zero behavior change.

All three modified call sites are mechanically identical after the reflow; the only difference is line-break placement. No logic, imports, or test assertions were altered.

No files require special attention.

Important Files Changed

Filename Overview
ord_interface/api/view.py Pure formatting reflow of two HTTPException calls to fit within the 88-character line limit — no logic changes.
ord_interface/api/view_test.py One test call reflowed to 88 chars — identical behavior, no logic changes.

Reviews (1): Last reviewed commit: "Reformat view.py to 88 chars to fix chec..." | Re-trigger Greptile

#187 introduced two HTTPException calls in view.py (and one test line in
view_test.py) wider than 88 chars after #188 lowered the line length.
Because it merged after #188 without rebasing, the `ruff format --check`
step in the check_python CI job has been failing on main ever since.

Pure `ruff format` reflow; no behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@skearnes
skearnes merged commit 789b804 into main Jun 21, 2026
16 checks passed
@skearnes
skearnes deleted the cleanup/format-view-py branch June 21, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant