Reformat view.py to 88 chars to fix red check_python on main - #194
Merged
Conversation
#187 introduced two HTTPException calls in view.py (and one test line in view_test.py) wider than 88 chars after #188 lowered the line length. Because it merged after #188 without rebasing, the `ruff format --check` step in the check_python CI job has been failing on main ever since. Pure `ruff format` reflow; no behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
main'scheck_pythonjob is currently red. #187 added twoHTTPExceptioncalls in view.py (and one line in view_test.py) wider than 88 chars; it merged after #188 lowered the ruff line length to 88, without rebasing, so theruff format --check ord_interfacestep has been failing onmainever since. #186 didn't touch these files.This is a pure
ruff formatreflow of those lines — no behavior change. It unblocks CI onmain(and on the other open cleanup PRs, whosecheck_pythoninherits the same tree).Verification
ruff format --check ord_interfaceclean.ruff checkclean.🤖 Generated with Claude Code
Greptile Summary
This is a pure
ruff formatreflow to bring twoHTTPExceptioncalls inview.pyand one test call inview_test.pywithin the 88-character line limit introduced in #188. There are no logic or behavior changes.view.py: TwoHTTPExceptionconstructions (404 and 500) split across multiple lines to satisfy the 88-char limit.view_test.py: Onetest_client.get(...)call reformatted identically for the same reason.Confidence Score: 5/5
Safe to merge — exclusively whitespace/line-wrap reformatting with zero behavior change.
All three modified call sites are mechanically identical after the reflow; the only difference is line-break placement. No logic, imports, or test assertions were altered.
No files require special attention.
Important Files Changed
Reviews (1): Last reviewed commit: "Reformat view.py to 88 chars to fix chec..." | Re-trigger Greptile