Skip to content

Pin ord-schema>=0.6.32,<0.7 - #197

Merged
skearnes merged 1 commit into
mainfrom
pin-ord-schema
Jun 24, 2026
Merged

Pin ord-schema>=0.6.32,<0.7#197
skearnes merged 1 commit into
mainfrom
pin-ord-schema

Conversation

@skearnes

@skearnes skearnes commented Jun 24, 2026

Copy link
Copy Markdown
Member

Floor the ord-schema dependency at 0.6.32 (the release that added the index-backed RDKit ORM helpers — contains_substructure/matches_smarts/is_similar/tanimoto via @>/% — and the reaction_provenance.doi index) and cap below 0.7, matching ord-app. Resolves to 0.6.33.

  • Replaces the unbounded >=0.6.
  • The uv.lock churn is the transitive-dep delta from bumping ord-schema 0.6.1 → 0.6.33 (it now pulls huggingface-hub, typer, etc.).
  • Gets fresh DB builds the doi index, and is the prerequisite for migrating the search queries onto the ORM helpers (separate PR).

🤖 Generated with Claude Code

Greptile Summary

This PR pins ord-schema from the unbounded >=0.6 to >=0.6.32,<0.7, flooring at the release that introduced index-backed RDKit ORM helpers (contains_substructure, matches_smarts, is_similar, tanimoto) and the reaction_provenance.doi index. The upper bound matches the constraint already used in ord-app.

  • pyproject.toml: single-line specifier change from >=0.6 to >=0.6.32,<0.7.
  • uv.lock: resolves to ord-schema 0.6.33 and carries the expected transitive-dep delta — most notably huggingface-hub and its tree (hf-xet, fsspec, filelock, rich, typer, shellingham), which were already noted and acknowledged in a prior review thread.

Confidence Score: 5/5

Safe to merge — the change is a mechanical dependency pin with no logic modifications.

The only code change is tightening the ord-schema version specifier; the lock file update is the expected resolver output. No application logic is touched, the upper bound prevents accidental 0.7 upgrades, and the transitive-dep concern (huggingface-hub weight) was acknowledged in a prior thread.

No files require special attention.

Important Files Changed

Filename Overview
pyproject.toml Pins ord-schema from unbounded >=0.6 to >=0.6.32,<0.7, adding a floor for ORM helpers and a cap matching ord-app
uv.lock Lock file updated: ord-schema 0.6.1→0.6.33, adds huggingface-hub and its transitive deps (hf-xet, fsspec, filelock, rich, typer, shellingham, markdown-it-py, mdurl)

Reviews (2): Last reviewed commit: "Pin ord-schema>=0.6.32,<0.7" | Re-trigger Greptile

Floor at 0.6.32 (the release adding the index-backed RDKit ORM helpers and the
reaction_provenance.doi index) and cap below 0.7, matching ord-app. Resolves to
0.6.33. The upper bound replaces the unbounded ">=0.6".

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Comment thread uv.lock
@skearnes
skearnes merged commit d47e04c into main Jun 24, 2026
16 checks passed
@skearnes
skearnes deleted the pin-ord-schema branch June 24, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant