Pin ord-schema>=0.6.32,<0.7 - #197
Merged
Merged
Conversation
Floor at 0.6.32 (the release adding the index-backed RDKit ORM helpers and the reaction_provenance.doi index) and cap below 0.7, matching ord-app. Resolves to 0.6.33. The upper bound replaces the unbounded ">=0.6". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Floor the
ord-schemadependency at 0.6.32 (the release that added the index-backed RDKit ORM helpers —contains_substructure/matches_smarts/is_similar/tanimotovia@>/%— and thereaction_provenance.doiindex) and cap below0.7, matching ord-app. Resolves to 0.6.33.>=0.6.uv.lockchurn is the transitive-dep delta from bumping ord-schema 0.6.1 → 0.6.33 (it now pullshuggingface-hub,typer, etc.).doiindex, and is the prerequisite for migrating the search queries onto the ORM helpers (separate PR).🤖 Generated with Claude Code
Greptile Summary
This PR pins
ord-schemafrom the unbounded>=0.6to>=0.6.32,<0.7, flooring at the release that introduced index-backed RDKit ORM helpers (contains_substructure,matches_smarts,is_similar,tanimoto) and thereaction_provenance.doiindex. The upper bound matches the constraint already used in ord-app.pyproject.toml: single-line specifier change from>=0.6to>=0.6.32,<0.7.uv.lock: resolves toord-schema 0.6.33and carries the expected transitive-dep delta — most notablyhuggingface-huband its tree (hf-xet,fsspec,filelock,rich,typer,shellingham), which were already noted and acknowledged in a prior review thread.Confidence Score: 5/5
Safe to merge — the change is a mechanical dependency pin with no logic modifications.
The only code change is tightening the ord-schema version specifier; the lock file update is the expected resolver output. No application logic is touched, the upper bound prevents accidental 0.7 upgrades, and the transitive-dep concern (huggingface-hub weight) was acknowledged in a prior thread.
No files require special attention.
Important Files Changed
Reviews (2): Last reviewed commit: "Pin ord-schema>=0.6.32,<0.7" | Re-trigger Greptile