fix: created unique IDs for each chart . #4189#4194
Conversation
…so create seperate syncId in order to avoid the issue.
Himanshu-Kathania
requested review from
brandonroberts,
nickytonline and
zeucapua
as code owners
👷 Deploy request for oss-insights pending review.Visit the deploys page to approve it
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord
1 participant
#4189
charts were sharing the same synchronization ID, which causes them to synchronize their tooltips and other interactions
Description
Generated unique IDs for each chart using uuid. also changed the syncId from number to string.
ex - const starsChartSyncId = uuidv4();
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
4189.mp4
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?