Skip to content

Commit cd2fb03

Browse files
committed
[receiver/oracledb] Address semconv review: singular units, lean descriptions, simpler tests
1 parent 4595ed1 commit cd2fb03

5 files changed

Lines changed: 86 additions & 92 deletions

File tree

receiver/oracledbreceiver/documentation.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -329,23 +329,23 @@ Fraction of host CPU time in use, as computed by Oracle V$SYSMETRIC (% Busy/(Idl
329329
330330
### oracledb.jvm.memory.committed
331331
332-
Committed (total) size in bytes of Oracle's in-database JVM (OJVM) call heap. Sourced from v$sysstat name java call heap total size. Mirrors semconv jvm.memory.committed for the embedded OJVM.
332+
Committed (total) size in bytes of Oracle's in-database JVM (OJVM) call heap.
333333
334334
| Unit | Metric Type | Value Type | Stability |
335335
| ---- | ----------- | ---------- | --------- |
336336
| By | Gauge | Int | Development |
337337
338338
### oracledb.jvm.memory.live
339339
340-
Size in bytes of live objects in Oracle's in-database JVM (OJVM) call heap. Sourced from v$sysstat name java call heap live size. No semconv jvm.memory equivalent.
340+
Size in bytes of live objects in Oracle's in-database JVM (OJVM) call heap.
341341
342342
| Unit | Metric Type | Value Type | Stability |
343343
| ---- | ----------- | ---------- | --------- |
344344
| By | Gauge | Int | Development |
345345
346346
### oracledb.jvm.memory.used
347347
348-
Used size in bytes of Oracle's in-database JVM (OJVM) call heap. Sourced from v$sysstat name java call heap used size. Mirrors semconv jvm.memory.used for the embedded OJVM.
348+
Used size in bytes of Oracle's in-database JVM (OJVM) call heap.
349349
350350
| Unit | Metric Type | Value Type | Stability |
351351
| ---- | ----------- | ---------- | --------- |
@@ -369,11 +369,11 @@ Number of logon operations
369369
370370
### oracledb.os.swaps
371371
372-
Number of OS swap operations, as accounted by Oracle. Sourced from v$sysstat name OS Swaps.
372+
Number of OS swap operations.
373373
374374
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic | Stability |
375375
| ---- | ----------- | ---------- | ----------------------- | --------- | --------- |
376-
| {swaps} | Sum | Int | Cumulative | true | Development |
376+
| {swap} | Sum | Int | Cumulative | true | Development |
377377
378378
### oracledb.parallel_operations_downgraded_1_to_25_pct
379379
@@ -549,15 +549,15 @@ Fraction of redo allocations that succeeded without space contention, as compute
549549
550550
### oracledb.session.stored_procedure.usage
551551
552-
Memory in bytes currently allocated for stored procedures in the session. Sourced from v$sysstat name session stored procedure space.
552+
Memory in bytes currently allocated for stored procedures in the session.
553553
554554
| Unit | Metric Type | Value Type | Stability |
555555
| ---- | ----------- | ---------- | --------- |
556556
| By | Gauge | Int | Development |
557557
558558
### oracledb.session.wait.time
559559
560-
Cumulative time sessions spent in non-idle waits, in seconds (converted from centiseconds). Sourced from v$sysstat name non-idle wait time.
560+
Cumulative time sessions spent in non-idle waits, in seconds.
561561
562562
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic | Stability |
563563
| ---- | ----------- | ---------- | ----------------------- | --------- | --------- |
@@ -567,21 +567,21 @@ Cumulative time sessions spent in non-idle waits, in seconds (converted from cen
567567
568568
| Name | Description | Values | Requirement Level | Semantic Convention |
569569
| ---- | ----------- | ------ | ----------------- | ------------------- |
570-
| oracledb.session.wait.state | Whether the session wait time/count is for idle or non-idle wait events. Oracle's v$sysstat currently exposes only the non-idle aggregate. | Str: ``non_idle`` | Recommended | - |
570+
| oracledb.session.wait.state | Whether the session wait time/count is for idle or non-idle wait events. | Str: ``non_idle`` | Recommended | - |
571571
572572
### oracledb.session.waits
573573
574-
Cumulative number of non-idle waits across sessions. Sourced from v$sysstat name non-idle wait count.
574+
Cumulative number of non-idle waits across sessions.
575575
576576
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic | Stability |
577577
| ---- | ----------- | ---------- | ----------------------- | --------- | --------- |
578-
| {waits} | Sum | Int | Cumulative | true | Development |
578+
| {wait} | Sum | Int | Cumulative | true | Development |
579579
580580
#### Attributes
581581
582582
| Name | Description | Values | Requirement Level | Semantic Convention |
583583
| ---- | ----------- | ------ | ----------------- | ------------------- |
584-
| oracledb.session.wait.state | Whether the session wait time/count is for idle or non-idle wait events. Oracle's v$sysstat currently exposes only the non-idle aggregate. | Str: ``non_idle`` | Recommended | - |
584+
| oracledb.session.wait.state | Whether the session wait time/count is for idle or non-idle wait events. | Str: ``non_idle`` | Recommended | - |
585585
586586
### oracledb.shared_pool.utilization
587587

receiver/oracledbreceiver/internal/metadata/generated_metrics.go

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/oracledbreceiver/internal/metadata/generated_metrics_test.go

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/oracledbreceiver/metadata.yaml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ attributes:
251251
description: "The timestamp when the session logged on, in ISO 8601 format (UTC)."
252252
type: string
253253
oracledb.session.wait.state:
254-
description: Whether the session wait time/count is for idle or non-idle wait events. Oracle's v$sysstat currently exposes only the non-idle aggregate.
254+
description: Whether the session wait time/count is for idle or non-idle wait events.
255255
type: string
256256
enum: [non_idle]
257257
oracledb.sid:
@@ -578,23 +578,23 @@ metrics:
578578
value_type: double
579579
unit: "%"
580580
oracledb.jvm.memory.committed:
581-
description: Committed (total) size in bytes of Oracle's in-database JVM (OJVM) call heap. Sourced from v$sysstat name java call heap total size. Mirrors semconv jvm.memory.committed for the embedded OJVM.
581+
description: Committed (total) size in bytes of Oracle's in-database JVM (OJVM) call heap.
582582
enabled: false
583583
stability: development
584584
gauge:
585585
value_type: int
586586
input_type: string
587587
unit: By
588588
oracledb.jvm.memory.live:
589-
description: Size in bytes of live objects in Oracle's in-database JVM (OJVM) call heap. Sourced from v$sysstat name java call heap live size. No semconv jvm.memory equivalent.
589+
description: Size in bytes of live objects in Oracle's in-database JVM (OJVM) call heap.
590590
enabled: false
591591
stability: development
592592
gauge:
593593
value_type: int
594594
input_type: string
595595
unit: By
596596
oracledb.jvm.memory.used:
597-
description: Used size in bytes of Oracle's in-database JVM (OJVM) call heap. Sourced from v$sysstat name java call heap used size. Mirrors semconv jvm.memory.used for the embedded OJVM.
597+
description: Used size in bytes of Oracle's in-database JVM (OJVM) call heap.
598598
enabled: false
599599
stability: development
600600
gauge:
@@ -629,15 +629,15 @@ metrics:
629629
input_type: string
630630
unit: "{operation}"
631631
oracledb.os.swaps:
632-
description: Number of OS swap operations, as accounted by Oracle. Sourced from v$sysstat name OS Swaps.
632+
description: Number of OS swap operations.
633633
enabled: false
634634
stability: development
635635
sum:
636636
aggregation_temporality: cumulative
637637
monotonic: true
638638
value_type: int
639639
input_type: string
640-
unit: "{swaps}"
640+
unit: "{swap}"
641641
oracledb.parallel_operations_downgraded_1_to_25_pct:
642642
description: Number of times parallel execution was requested and the degree of parallelism was reduced down to 1-25% because of insufficient parallel execution servers
643643
enabled: false
@@ -867,7 +867,7 @@ metrics:
867867
value_type: double
868868
unit: "%"
869869
oracledb.session.stored_procedure.usage:
870-
description: Memory in bytes currently allocated for stored procedures in the session. Sourced from v$sysstat name session stored procedure space.
870+
description: Memory in bytes currently allocated for stored procedures in the session.
871871
enabled: false
872872
stability: development
873873
gauge:
@@ -877,7 +877,7 @@ metrics:
877877
oracledb.session.wait.time:
878878
attributes:
879879
- oracledb.session.wait.state
880-
description: Cumulative time sessions spent in non-idle waits, in seconds (converted from centiseconds). Sourced from v$sysstat name non-idle wait time.
880+
description: Cumulative time sessions spent in non-idle waits, in seconds.
881881
enabled: false
882882
stability: development
883883
sum:
@@ -888,15 +888,15 @@ metrics:
888888
oracledb.session.waits:
889889
attributes:
890890
- oracledb.session.wait.state
891-
description: Cumulative number of non-idle waits across sessions. Sourced from v$sysstat name non-idle wait count.
891+
description: Cumulative number of non-idle waits across sessions.
892892
enabled: false
893893
stability: development
894894
sum:
895895
aggregation_temporality: cumulative
896896
monotonic: true
897897
value_type: int
898898
input_type: string
899-
unit: "{waits}"
899+
unit: "{wait}"
900900
oracledb.sessions.limit:
901901
description: Maximum limit of active sessions, -1 if unlimited.
902902
enabled: true

0 commit comments

Comments
 (0)