[receiver/osquery] implement scraper#47387
Merged
atoulme merged 1 commit intoopen-telemetry:mainfrom Apr 8, 2026
Merged
Conversation
Contributor
|
thanks! |
axw
reviewed
Apr 7, 2026
Comment on lines
+77
to
+83
| // Use a separate connection for queries in order to be able to recover from timed out queries | ||
| queryClient, err := or.connect(defaultClientConnectRetries) | ||
| if err != nil { | ||
| or.logger.Error("Could not connect to osquery socket", zap.Error(err)) | ||
| return err | ||
| } | ||
| defer queryClient.Close() |
Contributor
There was a problem hiding this comment.
Does the transport get closed when a query times out?
Contributor
Author
There was a problem hiding this comment.
this I'm not sure about. I also don't know if we should create a client per query. Definitely something to explore more.
Contributor
There was a problem hiding this comment.
👌 maybe worth adding a TODO to come back to it? Retrying 3x with 200ms in between is a bit arbitrary, so if nothing else we should clarify why this is even needed. e.g. is it to cater for osqueryd being unavailable at dial time? And we should ideally ensure the retry loop honours context cancellation.
No problem to do all that in a followup though, just my 2c
axw
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement the osquery receiver scraper.
Link to tracking issue
Fixes #30375
@smithclay please review