Skip to content

[receiver/apache] add request rate, transmitted-bytes rate, and worker limit metrics - #49029

Merged
ChrsMark merged 6 commits into
open-telemetry:mainfrom
sairaj18:feat/apachereceiver-rate-metrics
Aug 5, 2026
Merged

[receiver/apache] add request rate, transmitted-bytes rate, and worker limit metrics#49029
ChrsMark merged 6 commits into
open-telemetry:mainfrom
sairaj18:feat/apachereceiver-rate-metrics

Conversation

@sairaj18

@sairaj18 sairaj18 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description

Add three new metrics to the Apache receiver:

  1. apache.workers.limit (gauge, int) [disabled by default] - The total number of worker slots configured.
  2. apache.traffic.rate (gauge, double, By/s) [disabled by default] - The server's average bytes served per second since the server was started.
  3. apache.request.rate (gauge, double, {request}/s)- The server's average requests served per second since the server was started.

Link to tracking issue

Fixes #47061

Testing

  • Added ReqPerSec, BytesPerSec to the unit test mock server and updated the scraper assertion fixture in testdata/scraper/metrics.assert.yaml.
  • Updated testdata/integration/expected.yaml to include the three new metrics.

Documentation

  • Added attribute definitions in metadata.yaml.
  • Auto-generated documentation.md updated to reflect three new metrics.
  • Added changelog entry in .chloggen/47061-apache-rate-and-max-workers-metrics.yaml.

Authorship

  • I, a human, wrote this pull request description myself.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 12, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: sairaj18 / name: sairaj18 (83748e2)

@github-actions

Copy link
Copy Markdown
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

  • Read our Contributing Guidelines.
  • Sign the CLA if you haven't already.
  • First-time contributors should have at most one PR not marked as draft until their first PR is merged.
  • If your change isn't one of our priority components, reviews may take more time.
  • Give reviewers at least a few days before pinging them for feedback.
  • If you need help or struggle to move your PR forward:

@github-actions github-actions Bot added the first-time contributor PRs made by new contributors label Jun 12, 2026
@sairaj18
sairaj18 force-pushed the feat/apachereceiver-rate-metrics branch from 83748e2 to 8f53ff2 Compare June 12, 2026 06:56
@sairaj18 sairaj18 changed the title [receiver/apache] add request/traffic rate and max-workers metrics [receiver/apache] add request rate, transmitted-bytes rate, and worker limit metrics Jun 12, 2026
@sairaj18
sairaj18 force-pushed the feat/apachereceiver-rate-metrics branch from 8f53ff2 to 3815abb Compare June 16, 2026 05:33
@sairaj18
sairaj18 marked this pull request as ready for review June 16, 2026 05:33
@sairaj18
sairaj18 requested a review from a team as a code owner June 16, 2026 05:33
@sairaj18
sairaj18 requested a review from jmacd June 16, 2026 05:33
@github-actions
github-actions Bot requested review from colelaven and ishleenk17 June 16, 2026 05:33
@sairaj18
sairaj18 force-pushed the feat/apachereceiver-rate-metrics branch from 3815abb to 0d195c8 Compare June 16, 2026 08:59

@colelaven colelaven left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sairaj18, please read through the Open-Telemetry Generative AI Contribution Policy: https://github.com/open-telemetry/community/blob/main/policies/genai.md

This PR's description was clearly written with GenAI, even though the human authorship checkbox was checked.

Could you please rewrite the PR description manually?

@sairaj18
sairaj18 force-pushed the feat/apachereceiver-rate-metrics branch from 0d195c8 to ce438ab Compare June 17, 2026 06:54
@sairaj18

sairaj18 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Could you please rewrite the PR description manually?

Updated it. Thanks!

@sairaj18
sairaj18 force-pushed the feat/apachereceiver-rate-metrics branch from ce438ab to 2a5cb48 Compare June 17, 2026 07:09
@sairaj18
sairaj18 requested a review from colelaven June 17, 2026 07:50
@sairaj18

Copy link
Copy Markdown
Contributor Author

Hey @colelaven / @jmacd / @ishleenk17 Can you please review the PR.

@sairaj18

Copy link
Copy Markdown
Contributor Author

Hey @colelaven / @jmacd / @ishleenk17 / @dashpole can you review the PR?

Comment thread .chloggen/47061-apache-rate-and-max-workers-metrics.yaml Outdated
@colelaven

Copy link
Copy Markdown
Member

Could you please rewrite the PR description manually?

Updated it. Thanks!

Hi @sairaj18, this PR description is even more verbose now. Did you write it yourself or use GenAI to write it? Please rewrite it manually when you have a moment.

@sairaj18
sairaj18 force-pushed the feat/apachereceiver-rate-metrics branch from 2a5cb48 to dc3a5e1 Compare June 24, 2026 06:42
@sairaj18

Copy link
Copy Markdown
Contributor Author

Hi @sairaj18, this PR description is even more verbose now. Did you write it yourself or use GenAI to write it? Please rewrite it manually when you have a moment.

Hey @colelaven, I wrote the description manually earlier. I've updated it manually again. Can you check and review the PR again. Thanks!

@sairaj18
sairaj18 force-pushed the feat/apachereceiver-rate-metrics branch from dc3a5e1 to ac10ae9 Compare June 24, 2026 06:46
@sairaj18
sairaj18 requested a review from colelaven June 24, 2026 06:47

@colelaven colelaven left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can name one of the metrics better, otherwise this PR is looking pretty good 👍

Comment thread receiver/apachereceiver/metadata.yaml Outdated
@colelaven

Copy link
Copy Markdown
Member

Hi @sairaj18, this PR description is even more verbose now. Did you write it yourself or use GenAI to write it? Please rewrite it manually when you have a moment.

Hey @colelaven, I wrote the description manually earlier. I've updated it manually again. Can you check and review the PR again. Thanks!

Thank you, the description is easier to read now.

@sairaj18
sairaj18 force-pushed the feat/apachereceiver-rate-metrics branch from ac10ae9 to c3e4b4a Compare June 26, 2026 06:21
@sairaj18
sairaj18 requested a review from colelaven June 26, 2026 06:25
@sairaj18
sairaj18 force-pushed the feat/apachereceiver-rate-metrics branch from c3e4b4a to a307e84 Compare June 26, 2026 06:26
@sairaj18

Copy link
Copy Markdown
Contributor Author

Hey @colelaven I have addressed your comment. Can you review the PR. Thanks!

@sairaj18

sairaj18 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

hey @dashpole @jmacd @ishleenk17 Could you please review this PR?

@sairaj18
sairaj18 force-pushed the feat/apachereceiver-rate-metrics branch from a307e84 to 1aa785e Compare July 1, 2026 11:03
@sairaj18

sairaj18 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Hi @dashpole, I was just wondering if you'd be able to take a look at this PR. Thanks.

Comment thread receiver/apachereceiver/testdata/integration/expected.yaml Outdated
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 14, 2026

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-08-05 06:39 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@sairaj18
sairaj18 force-pushed the feat/apachereceiver-rate-metrics branch from 6b2d5f1 to 6a8e9a5 Compare July 31, 2026 04:51
@sairaj18

Copy link
Copy Markdown
Contributor Author

Hey @dashpole can you review the PR again. Thanks!

@singhvibhanshu

Copy link
Copy Markdown
Member

@sairaj18,

Generated code is out of date for group 'receiver-0', please run "make generate" and commit the changes in this PR.

go package imports not formatted, please run "make gogci" and commit the changes in this PR.

@singhvibhanshu

Copy link
Copy Markdown
Member

@sairaj18,
We'll get this in once you fix the CI failures

…r limit metrics

Add apache.request.rate, apache.io.transmitted.rate, and apache.worker.limit,
sourced from the ReqPerSec/BytesPerSec fields and the scoreboard length of
mod_status's server-status?auto output. Names and units follow OTel semantic
conventions and the maintainer feedback on open-telemetry#47223.

Assisted-by: Claude Opus 4.8
Signed-off-by: sairaj18 <sairajsunny18@gmail.com>
@sairaj18
sairaj18 force-pushed the feat/apachereceiver-rate-metrics branch from 6a8e9a5 to 55ccbb8 Compare August 5, 2026 04:46
@singhvibhanshu

Copy link
Copy Markdown
Member

/workflow-approve

@singhvibhanshu singhvibhanshu added the ready to merge Code review completed; ready to merge by maintainers label Aug 5, 2026
@singhvibhanshu

Copy link
Copy Markdown
Member

/workflow-approve

@singhvibhanshu

Copy link
Copy Markdown
Member

/workflow-approve


| Unit | Metric Type | Value Type | Stability |
| ---- | ----------- | ---------- | --------- |
| {worker} | Gauge | Int | Development |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an updowncounter type fits better here? Can be handled in follow-up PR.

@ChrsMark
ChrsMark merged commit 91a670c into open-telemetry:main Aug 5, 2026
134 checks passed
@otelbot

otelbot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution @sairaj18! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-time contributor PRs made by new contributors ready to merge Code review completed; ready to merge by maintainers receiver/apache

Projects

None yet

Development

Successfully merging this pull request may close these issues.

receiver/apache: Add metrics for max workers, bytes per second, and requests per second

5 participants