[receiver/apache] add request rate, transmitted-bytes rate, and worker limit metrics - #49029
Conversation
|
|
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
|
83748e2 to
8f53ff2
Compare
8f53ff2 to
3815abb
Compare
3815abb to
0d195c8
Compare
There was a problem hiding this comment.
Hi @sairaj18, please read through the Open-Telemetry Generative AI Contribution Policy: https://github.com/open-telemetry/community/blob/main/policies/genai.md
This PR's description was clearly written with GenAI, even though the human authorship checkbox was checked.
Could you please rewrite the PR description manually?
0d195c8 to
ce438ab
Compare
Updated it. Thanks! |
ce438ab to
2a5cb48
Compare
|
Hey @colelaven / @jmacd / @ishleenk17 Can you please review the PR. |
|
Hey @colelaven / @jmacd / @ishleenk17 / @dashpole can you review the PR? |
Hi @sairaj18, this PR description is even more verbose now. Did you write it yourself or use GenAI to write it? Please rewrite it manually when you have a moment. |
2a5cb48 to
dc3a5e1
Compare
Hey @colelaven, I wrote the description manually earlier. I've updated it manually again. Can you check and review the PR again. Thanks! |
dc3a5e1 to
ac10ae9
Compare
colelaven
left a comment
There was a problem hiding this comment.
I think we can name one of the metrics better, otherwise this PR is looking pretty good 👍
Thank you, the description is easier to read now. |
ac10ae9 to
c3e4b4a
Compare
c3e4b4a to
a307e84
Compare
|
Hey @colelaven I have addressed your comment. Can you review the PR. Thanks! |
|
hey @dashpole @jmacd @ishleenk17 Could you please review this PR? |
a307e84 to
1aa785e
Compare
|
Hi @dashpole, I was just wondering if you'd be able to take a look at this PR. Thanks. |
Pull request dashboard statusMerged · refreshed 2026-08-05 06:39 UTC Status above doesn't look right?
|
6b2d5f1 to
6a8e9a5
Compare
|
Hey @dashpole can you review the PR again. Thanks! |
|
|
@sairaj18, |
…r limit metrics Add apache.request.rate, apache.io.transmitted.rate, and apache.worker.limit, sourced from the ReqPerSec/BytesPerSec fields and the scoreboard length of mod_status's server-status?auto output. Names and units follow OTel semantic conventions and the maintainer feedback on open-telemetry#47223. Assisted-by: Claude Opus 4.8 Signed-off-by: sairaj18 <sairajsunny18@gmail.com>
6a8e9a5 to
55ccbb8
Compare
|
/workflow-approve |
|
/workflow-approve |
|
/workflow-approve |
|
|
||
| | Unit | Metric Type | Value Type | Stability | | ||
| | ---- | ----------- | ---------- | --------- | | ||
| | {worker} | Gauge | Int | Development | |
There was a problem hiding this comment.
Maybe an updowncounter type fits better here? Can be handled in follow-up PR.
Description
Add three new metrics to the Apache receiver:
apache.workers.limit(gauge, int) [disabled by default] - The total number of worker slots configured.apache.traffic.rate(gauge, double,By/s) [disabled by default] - The server's average bytes served per second since the server was started.apache.request.rate(gauge, double,{request}/s)- The server's average requests served per second since the server was started.Link to tracking issue
Fixes #47061
Testing
ReqPerSec,BytesPerSecto the unit test mock server and updated the scraper assertion fixture intestdata/scraper/metrics.assert.yaml.testdata/integration/expected.yamlto include the three new metrics.Documentation
documentation.mdupdated to reflect three new metrics..chloggen/47061-apache-rate-and-max-workers-metrics.yaml.Authorship