[exporter/prometheus_remote_writeexporter] Fix WAL buffered data stall … - #49131
Conversation
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
|
There was a problem hiding this comment.
Pull request overview
This PR addresses an idle-stall scenario in the Prometheus Remote Write exporter WAL reader by ensuring the export/truncation loop can make progress even when no new WAL entries arrive, and improves WAL telemetry by adding exporter identity attributes to disambiguate metrics across multiple exporter instances.
Changes:
- Add an
exporterattribute to WAL telemetry metrics for per-exporter disambiguation. - Introduce a bounded wait (timeout) when the WAL read hits
ErrNotFound, allowing the export loop to periodically re-check truncation/export conditions. - On read timeout, opportunistically flush buffered requests when the truncation timer has fired.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6a2aa4a to
ed8cea8
Compare
charanck9
left a comment
There was a problem hiding this comment.
resolved the comments
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Pull request dashboard statusMerged · refreshed 2026-08-05 06:39 UTC Status above doesn't look right?
|
krajorama
left a comment
There was a problem hiding this comment.
The fix is looking good, but please add chloggen entry and also split out the unrelated attribute change. Smaller PRs are faster to approve and merge.
charanck9
left a comment
There was a problem hiding this comment.
Comments addressed
5b26578 to
5ba18fc
Compare
Signed-off-by: charanck9 <charan.ulasala.ext@ericsson.com>
5ba18fc to
7eff7e3
Compare
|
Hi @charanck9 — just a friendly reminder that this pull request is waiting on you. There are still items that need your attention. See the dashboard status comment for the full list. You don't need to push a code change to hand it back — replying to move each discussion forward is enough, whether that's answering a question, explaining why no change is needed, or asking a follow-up. The dashboard then automatically routes it back to reviewers. If you believe this pull request is incorrectly routed as waiting on the author, comment |
|
/workflow-approve |
|
/rerun |
|
/workflow-approve |
|
Thank you for your contribution @charanck9! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
…on idle
Add a timeout to the WAL read wait so that buffered entries are flushed even when no new data arrives. Previously, readPrompbFromWAL would block indefinitely on rNotify when the WAL was empty, preventing the truncation timer in continuallyPopWALThenExport from ever firing. This caused buffered requests to remain unsent until the next write.
Also add the exporter ID to WAL telemetry attributes for disambiguation when multiple exporters share a collector.
Description
Link to tracking issue
#49130
Fixes
Testing
Documentation
Authorship