[receiver/sqlserver] Add access methods and buffer pool metrics - #49185
Merged
atoulme merged 11 commits intoJul 2, 2026
Merged
Conversation
Signed-off-by: akshasri <akshaysrivastava@splunk.com>
…thods-and-buffer-pool # Conflicts: # receiver/sqlserverreceiver/internal/metadata/generated_metrics_test.go
Contributor
|
LGTM ✅ |
akshays-19
marked this pull request as ready for review
June 23, 2026 08:45
github-actions
Bot
added
receiver/sqlserver
Run Windows
crobert-1
reviewed
Jun 24, 2026
crobert-1
reviewed
Jun 26, 2026
crobert-1
approved these changes
Jun 30, 2026
crobert-1
left a comment
crobert-1
left a comment
Member
There was a problem hiding this comment.
Looks good, just one more nit about alphabetical order
crobert-1
added
the
ready to merge
tommyers-elastic
pushed a commit
to tommyers-elastic/opentelemetry-collector-contrib
that referenced
this pull request
Jul 3, 2026
…-telemetry#49185) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds 7 new opt-in metrics to the sqlserverreceiver covering Access Methods and Buffer Pool Extensions. These consolidate 14 separate performance counters into attribute-based OTLP metrics, following the receiver's existing consolidation pattern (e.g., sqlserver.page.operation with an attribute). All new metrics reuse the existing sys.dm_os_performance_counters query path — no new DMVs required. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#49182 <!--Describe what testing was performed and which tests were added.--> #### Testing - Unit tests for all 7 new metrics - Integration tests against SQL Server instance - metadata.yaml updated with metric definitions - Documentation updated <!--Describe the documentation added.--> #### Documentation <!--Authorship attestation. See AGENTS.md for details. AI agents must not check this box on behalf of the user; the human author must check it themselves before the PR is ready for review.--> #### Authorship - [x] I, a human, wrote this pull request description myself. <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: akshasri <akshaysrivastava@splunk.com>
akhileshsingh85
pushed a commit
to akhileshsingh85/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2026
…-telemetry#49185) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds 7 new opt-in metrics to the sqlserverreceiver covering Access Methods and Buffer Pool Extensions. These consolidate 14 separate performance counters into attribute-based OTLP metrics, following the receiver's existing consolidation pattern (e.g., sqlserver.page.operation with an attribute). All new metrics reuse the existing sys.dm_os_performance_counters query path — no new DMVs required. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#49182 <!--Describe what testing was performed and which tests were added.--> #### Testing - Unit tests for all 7 new metrics - Integration tests against SQL Server instance - metadata.yaml updated with metric definitions - Documentation updated <!--Describe the documentation added.--> #### Documentation <!--Authorship attestation. See AGENTS.md for details. AI agents must not check this box on behalf of the user; the human author must check it themselves before the PR is ready for review.--> #### Authorship - [x] I, a human, wrote this pull request description myself. <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: akshasri <akshaysrivastava@splunk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds 7 new opt-in metrics to the sqlserverreceiver covering Access Methods and Buffer Pool Extensions. These consolidate 14 separate performance counters into attribute-based OTLP metrics, following the receiver's existing consolidation pattern (e.g., sqlserver.page.operation with an attribute).
All new metrics reuse the existing sys.dm_os_performance_counters query path — no new DMVs required.
Link to tracking issue
Fixes #49182
Testing
Documentation
Authorship