[processor/metricstransform] Fix silent data loss for single Summary metric in combine action - #49794
Merged
dmitryax merged 4 commits intoAug 5, 2026
Conversation
Pull request dashboard statusMerged · refreshed 2026-08-05 11:32 UTC Status above doesn't look right?
|
…metric in combine action
himanshu130700
force-pushed
the
fix/metricstransform-combine-summary-single-49693
branch
from
July 21, 2026 11:31
2270495 to
98b1075
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a metrics transform processor edge case where combine on a single matched Summary metric could silently drop all Summary datapoints, by ensuring Summary metrics are rejected before the len(metrics) <= 1 early-return.
Changes:
- Update
canBeCombinedto always guard against Summary metrics (including the single-match case). - Add a regression test covering combine + single Summary match to ensure the metric passes through unchanged.
- Add a user-facing changelog entry describing the behavioral fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| processor/metricstransformprocessor/metrics_transform_processor_otlp.go | Moves the Summary-type guard ahead of the len <= 1 early exit to prevent combine from proceeding for Summary metrics. |
| processor/metricstransformprocessor/metrics_transform_processor_testcases_test.go | Adds a regression test ensuring a single matched Summary metric is not combined/dropped. |
| .chloggen/49693-metricstransform-combine-summary-single.yaml | Adds a changelog entry documenting the fix for silent Summary datapoint loss. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
dmitryax
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #49693
Documentation
Authorship