Skip to content

[processor/metricstransform] Fix silent data loss for single Summary metric in combine action - #49794

Merged
dmitryax merged 4 commits into
open-telemetry:mainfrom
himanshu130700:fix/metricstransform-combine-summary-single-49693
Aug 5, 2026
Merged

[processor/metricstransform] Fix silent data loss for single Summary metric in combine action#49794
dmitryax merged 4 commits into
open-telemetry:mainfrom
himanshu130700:fix/metricstransform-combine-summary-single-49693

Conversation

@himanshu130700

Copy link
Copy Markdown
Contributor

fixes #49693

Documentation

Authorship

  • I, a human, wrote this pull request description myself.

@himanshu130700
himanshu130700 requested review from a team and dmitryax as code owners July 21, 2026 11:23
@github-actions github-actions Bot added the processor/metricstransform Metrics Transform processor label Jul 21, 2026
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 21, 2026

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-08-05 11:32 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@himanshu130700
himanshu130700 force-pushed the fix/metricstransform-combine-summary-single-49693 branch from 2270495 to 98b1075 Compare July 21, 2026 11:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a metrics transform processor edge case where combine on a single matched Summary metric could silently drop all Summary datapoints, by ensuring Summary metrics are rejected before the len(metrics) <= 1 early-return.

Changes:

  • Update canBeCombined to always guard against Summary metrics (including the single-match case).
  • Add a regression test covering combine + single Summary match to ensure the metric passes through unchanged.
  • Add a user-facing changelog entry describing the behavioral fix.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
processor/metricstransformprocessor/metrics_transform_processor_otlp.go Moves the Summary-type guard ahead of the len <= 1 early exit to prevent combine from proceeding for Summary metrics.
processor/metricstransformprocessor/metrics_transform_processor_testcases_test.go Adds a regression test ensuring a single matched Summary metric is not combined/dropped.
.chloggen/49693-metricstransform-combine-summary-single.yaml Adds a changelog entry documenting the fix for silent Summary datapoint loss.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread processor/metricstransformprocessor/metrics_transform_processor_otlp.go Outdated
Comment thread processor/metricstransformprocessor/metrics_transform_processor_otlp.go Outdated
himanshu130700 and others added 2 commits July 22, 2026 15:39
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@dmitryax
dmitryax merged commit d331cb6 into open-telemetry:main Aug 5, 2026
133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

processor/metricstransform Metrics Transform processor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[processor/metricstransform]: combine action silently drops Summary metric data points when only one metric matches

3 participants