-
Notifications
You must be signed in to change notification settings - Fork 3.8k
oracledbreceiver: optimize query sample collection by splitting into two-pass approach to avoid full cursor cache scan #49875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tharun0064
wants to merge
6
commits into
open-telemetry:main
Choose a base branch
from
newrelic-forks:oracledbreceiver-query-sample-two-pass
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1edf3dc
oracledbreceiver: split query-sample collection into two queries to a…
tharun0064 ef31e02
add batching to avoid 10k limit
tharun0064 29d3717
link issue
tharun0064 5c3de48
fix checks
tharun0064 abe9939
Added testcase for batching and fixed placeholder bug
tharun0064 74113f2
fix checks
tharun0064 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog) | ||
| component: receiver/oracledb | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Speed up query-sample collection by splitting it into two queries so the SQL text/plan lookup no longer joins V$SESSION against the entire cursor cache. | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| issues: [49874] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: | | ||
| The session query no longer joins V$SQL (which forced Oracle to scan the whole | ||
| shared-pool cursor cache and materialize SQL_FULLTEXT for every cursor). Instead, | ||
| the receiver collects the active sessions first, then fetches SQL_FULLTEXT / | ||
| CHILD_ADDRESS / PLAN_HASH_VALUE from V$SQL for only those sql_ids via | ||
| WHERE SQL_ID IN (...), and joins the results in the collector. Sessions whose | ||
| cursor has aged out of the shared pool are skipped, preserving the previous | ||
| inner-join semantics. Note: the two queries are issued at slightly different SCNs; | ||
| for actively-executing cursors this is immaterial (they are pinned in the shared | ||
| pool), but cursors that age out between Pass-1 and Pass-2 will not appear in the | ||
| output, which matches the previous inner-join semantics. | ||
|
|
||
| # If your change doesn't affect end users or the exported elements of any package, | ||
| # you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
| # Optional: The change log or logs in which this entry should be included. | ||
| # e.g. '[user]' or '[user, api]' | ||
| # Include 'user' if the change is relevant to end users. | ||
| # Include 'api' if there is a change to a library API. | ||
| # Default: '[user]' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests route through
fakeDbClient, whosemetricRows(context.Context, ...any)discards both the SQL text and the bind args and returns canned rows. So none of the sample tests validate the batching inenrichSamplesWithSQLStats: every case uses ≤3 sql_ids (one batch), and even at >1000 the fake would return the same rows and hide a placeholder/arg mismatch.Could you add a test that drives >1000 distinct sql_ids and asserts on the generated SQL + args? Something like:
On the current code this fails at batch 2 (
:1,and:1000)are absent because it emits:1001..:2000); with the placeholder fix it passes and also proves the cross-batch join reassembles text/plan correctly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a test case to cover this scenerio