[exporter/prometheus_remote_write] Add exporter ID to WAL telemetry attributes - #49944
Merged
Merged
Conversation
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
|
Pull request dashboard statusMerged · refreshed 2026-08-05 23:12 UTC Status above doesn't look right?
|
charanck9
force-pushed
the
prw-wal-exporter-attribute
branch
from
July 29, 2026 10:40
c49efd6 to
ef0893c
Compare
dashpole
reviewed
Jul 29, 2026
dashpole
reviewed
Jul 29, 2026
dashpole
left a comment
Contributor
There was a problem hiding this comment.
We would ideally use otelcol.component.id, but the rest of the prw exporter self-obs metrics already use exporter. We can make that switch at a future point for the whole exporter.
charanck9
force-pushed
the
prw-wal-exporter-attribute
branch
2 times, most recently
from
August 5, 2026 07:59
6ec403f to
c8cf3d8
Compare
…ttributes Signed-off-by: charanck9 <charan.ulasala.ext@ericsson.com>
charanck9
force-pushed
the
prw-wal-exporter-attribute
branch
from
August 5, 2026 08:03
c8cf3d8 to
e1e7f6c
Compare
charanck9
commented
Aug 5, 2026
charanck9
left a comment
Contributor
Author
There was a problem hiding this comment.
comments are addressed
Contributor
|
Thank you for your contribution @charanck9! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running multiple prometheusremotewrite exporter instances (e.g.,
prometheusremotewrite/ext and prometheusremotewrite/internal), the WAL telemetry
metrics (like wal_lag) have no exporter label, making it impossible to tell which
instance they belong to. The exporter-level metrics correctly include this label,
but the WAL metrics initialize otelAttrs as an empty slice.
For example, otelcol_exporter_prometheusremotewrite_wal_lag currently has no
component identifier:
otelcol_exporter_prometheusremotewrite_wal_lag{instance="ip:port", job="https",
namespace="test", pod_name="collector-6b97f867d4-dhds4", service_name="collector"}
This change sets the "exporter" attribute (the component ID) on the WAL telemetry
so the metrics can be distinguished per exporter instance.
Link to tracking issue
#49130
Fixes
Testing
Documentation
Authorship