Autogenerate config marshal and unmarshal test with datagen - #14599
Autogenerate config marshal and unmarshal test with datagen#14599iblancasa wants to merge 26 commits into
Conversation
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (87.50%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #14599 +/- ##
==========================================
- Coverage 90.38% 90.37% -0.01%
==========================================
Files 702 702
Lines 54097 54127 +30
==========================================
+ Hits 48893 48919 +26
- Misses 4054 4057 +3
- Partials 1150 1151 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
evan-bradley
left a comment
There was a problem hiding this comment.
Not sure where to add these, but can you add tests that use "bad" example configs to show where the TestComponentConfigMarshal test fails?
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Merging this PR will improve performance by 34.73%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | BenchmarkBatchMetricProcessor2k |
186.2 ms | 138.2 ms | +34.73% |
Comparing iblancasa:12906 (29d09fd) with main (98f555d)
Footnotes
-
76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
I'm trying to make this PR happen but there are too many issues with contrib :/ |
|
@andrzej-stencel @evan-bradley what do you think about adding a new field to mdatagen to generate this test for the different components? I propose something like:
|
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description
Add new test to ensure configuration can be marshaled and unmarshaled.
Link to tracking issue
Fixes #11711, #12906