Skip to content

[chore][cmd/mdatagen] Enhance schema ID resolution for local references - #14770

Merged
dmitryax merged 3 commits into
open-telemetry:mainfrom
jkoronaAtCisco:fix_jsonschema_generator
Mar 18, 2026
Merged

[chore][cmd/mdatagen] Enhance schema ID resolution for local references#14770
dmitryax merged 3 commits into
open-telemetry:mainfrom
jkoronaAtCisco:fix_jsonschema_generator

Conversation

@jkoronaAtCisco

@jkoronaAtCisco jkoronaAtCisco commented Mar 16, 2026

Copy link
Copy Markdown
Member

Description

This pull request provides fix for json schema generator: fixed a gap in schema ID resolution algorithm: local refs with relative paths (./...) were previously not resolved against a local-absolute origin schema ID — they are now correctly joined.

Link to tracking issue

Related to #14559

Testing

New test cases added to namespace_test.go

@jkoronaAtCisco
jkoronaAtCisco requested review from a team and dmitryax as code owners March 16, 2026 17:04
@codspeed-hq

codspeed-hq Bot commented Mar 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 7 untouched benchmarks
⏩ 76 skipped benchmarks1


Comparing jkoronaAtCisco:fix_jsonschema_generator (38cf8e9) with main (ec18380)

Open in CodSpeed

Footnotes

  1. 76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov

codecov Bot commented Mar 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.39%. Comparing base (ec18380) to head (38cf8e9).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14770      +/-   ##
==========================================
- Coverage   91.39%   91.39%   -0.01%     
==========================================
  Files         695      695              
  Lines       44400    44403       +3     
==========================================
  Hits        40581    40581              
- Misses       2686     2688       +2     
- Partials     1133     1134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmitryax
dmitryax added this pull request to the merge queue Mar 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 17, 2026
@dmitryax
dmitryax added this pull request to the merge queue Mar 18, 2026
Merged via the queue into open-telemetry:main with commit acdfff0 Mar 18, 2026
66 checks passed
@jkoronaAtCisco
jkoronaAtCisco deleted the fix_jsonschema_generator branch March 19, 2026 10:16
blakerouse pushed a commit to blakerouse/opentelemetry-collector that referenced this pull request May 13, 2026
…es (open-telemetry#14770)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This pull request provides fix for json schema generator: fixed a gap in
schema ID resolution algorithm: local refs with relative paths (./...)
were previously not resolved against a local-absolute origin schema ID —
they are now correctly joined.

<!-- Issue number if applicable -->
#### Link to tracking issue
Related to open-telemetry#14559 

<!--Describe what testing was performed and which tests were added.-->
#### Testing

 New test cases added to namespace_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants