[cmd/mdatagen] Localize same-repo schema refs using import root path - #14773
Merged
dmitryax merged 3 commits intoMar 17, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (92.59%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## prepare-release-prs/0.148.0 #14773 +/- ##
===============================================================
- Coverage 91.38% 91.37% -0.01%
===============================================================
Files 695 695
Lines 44390 44400 +10
===============================================================
+ Hits 40567 40572 +5
- Misses 2689 2692 +3
- Partials 1134 1136 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
atoulme
approved these changes
Mar 17, 2026
This change make mdatagen to rewrite same-repo schema references to absolute local refs during schema generation and resolution. Instead of keeping refs like go.opentelemetry.io/collector/filter.config as versioned external references, mdatagen now converts them to /filter.config when the ref belongs to the current repo import root. This avoids generator failures in release/version-bump PRs where mdatagen would otherwise try to resolve schemas from a not-yet-published version tag or .schemas/<next-version> cache. See https://github.com/open-telemetry/opentelemetry-collector/actions/runs/23166843771/job/67309001982?pr=14772
dmitryax
force-pushed
the
fix-cfggen-blocker
branch
from
March 17, 2026 03:01
9b89ef3 to
f408633
Compare
dmitryax
merged commit Mar 17, 2026
d6b8254
into
open-telemetry:prepare-release-prs/0.148.0
44 of 45 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #14774, against failing release branch
This change make mdatagen to rewrite same-repo schema references to absolute local refs during schema generation and resolution.
Instead of keeping refs like go.opentelemetry.io/collector/filter.config as versioned external references, mdatagen now converts them to /filter.config when the ref belongs to the current repo import root.
This avoids generator failures in release/version-bump PRs where mdatagen would otherwise try to resolve schemas from a not-yet-published version tag or .schemas/ cache. See https://github.com/open-telemetry/opentelemetry-collector/actions/runs/23166843771/job/67309001982?pr=14772