Skip to content

Support of Exponential histograms in metadatagen - #15057

Open
gizas wants to merge 14 commits into
open-telemetry:mainfrom
gizas:exponential_metadata
Open

Support of Exponential histograms in metadatagen#15057
gizas wants to merge 14 commits into
open-telemetry:mainfrom
gizas:exponential_metadata

Conversation

@gizas

@gizas gizas commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Feature

Description

Add support to the metadatagen tool for the exponential histogram configuration. This will be handled by [Histogram]: aggregation: <explicit|exponential> field that is introduced.

So this generates the config in the metadatagen.
If the user doesn't call Views() and register it with the SDK MeterProvider, the histogram instrument still works — it just falls back to explicit bucket histogram behavior (the SDK default). The exponential aggregation is opt-in at the SDK level, not at the instrument level.

Link to tracking issue

Fixes ##13368

Testing

See the tests added in this PR

Documentation

See cmd/mdatagen/metadata-schema.yaml

gizas added 5 commits April 2, 2026 16:39
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
@gizas
gizas requested review from a team and dmitryax as code owners April 3, 2026 14:08
@codecov

codecov Bot commented Apr 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.03%. Comparing base (16076b2) to head (c81fa72).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15057      +/-   ##
==========================================
+ Coverage   91.02%   91.03%   +0.01%     
==========================================
  Files         727      727              
  Lines       48155    48210      +55     
==========================================
+ Hits        43835    43890      +55     
  Misses       3002     3002              
  Partials     1318     1318              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gizas added 2 commits April 3, 2026 17:24
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
@codspeed-hq

codspeed-hq Bot commented Apr 3, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 3 untouched benchmarks
🗄️ 4 archived benchmarks run1


Comparing gizas:exponential_metadata (c81fa72) with main (16076b2)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

gizas added 4 commits April 3, 2026 17:34
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
@gizas

gizas commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

@dmitryax sorry if I rushed with the implementation. From my tests I have seen that only views configuration is the one that gives support of exponential histograms in my setup that is why I followed this approach in this pr.

But lets discuss any ideas and we can change whatever you think

@gizas

gizas commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

@dmitryax sorry for direct ping here: Any chance you had a look for this ? Let me know if you have any time to discuss the approach

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label May 6, 2026
@gizas

gizas commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

@dmitryax another ping in order not this to remain stale

@github-actions github-actions Bot removed the Stale label May 7, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label May 22, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions Bot closed this Jun 5, 2026
@dmitryax dmitryax reopened this Jul 14, 2026
@dmitryax

Copy link
Copy Markdown
Member

@gizas sorry for not replying earlier. Are you still interested? If so, I can review after rebase

gizas added 2 commits July 15, 2026 12:49
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
@github-actions
github-actions Bot requested a review from bogdandrutu July 15, 2026 10:03
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
@gizas

gizas commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@dmitryax thank you! I rebased. Sure if you think is valuable it can be of some use for us

@github-actions github-actions Bot removed the Stale label Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants