[chore] [scraperhelper] add more unit tests - #15125
Conversation
Add tests to the internal/controller package, so we have baseline coverage before making the changes in open-telemetry#15116.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15125 +/- ##
=======================================
Coverage 91.24% 91.24%
=======================================
Files 699 699
Lines 44913 44913
=======================================
+ Hits 40979 40980 +1
+ Misses 2786 2785 -1
Partials 1148 1148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 31.92%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | BenchmarkHTTPProtoLogsSequential |
3.7 ms | 5.1 ms | -26.32% |
| ❌ | BenchmarkGRPCLogsSequential |
4.3 ms | 6.3 ms | -31.92% |
Comparing axw:scraperherlper-controller-tests (fae92cf) with main (307e3ab)
Footnotes
-
76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
7201768
Description
Add tests to the internal/controller package, so we have baseline coverage before making the changes in
#15116.
Link to tracking issue
N/A
Testing
Yes
Documentation
No