Skip to content

[chore] [scraperhelper] add more unit tests - #15125

Merged
codeboten merged 2 commits into
open-telemetry:mainfrom
axw:scraperherlper-controller-tests
Apr 17, 2026
Merged

[chore] [scraperhelper] add more unit tests#15125
codeboten merged 2 commits into
open-telemetry:mainfrom
axw:scraperherlper-controller-tests

Conversation

@axw

@axw axw commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Description

Add tests to the internal/controller package, so we have baseline coverage before making the changes in
#15116.

Link to tracking issue

N/A

Testing

Yes

Documentation

No

Add tests to the internal/controller package, so we have baseline
coverage before making the changes in
open-telemetry#15116.
@codecov

codecov Bot commented Apr 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.24%. Comparing base (307e3ab) to head (fae92cf).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15125   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files         699      699           
  Lines       44913    44913           
=======================================
+ Hits        40979    40980    +1     
+ Misses       2786     2785    -1     
  Partials     1148     1148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axw
axw marked this pull request as ready for review April 16, 2026 07:22
@axw
axw requested a review from a team as a code owner April 16, 2026 07:22
@axw
axw requested a review from jade-guiton-dd April 16, 2026 07:22
@codeboten
codeboten enabled auto-merge April 17, 2026 16:03
@codspeed-hq

codspeed-hq Bot commented Apr 17, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 31.92%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 5 untouched benchmarks
⏩ 76 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
BenchmarkHTTPProtoLogsSequential 3.7 ms 5.1 ms -26.32%
BenchmarkGRPCLogsSequential 4.3 ms 6.3 ms -31.92%

Comparing axw:scraperherlper-controller-tests (fae92cf) with main (307e3ab)

Open in CodSpeed

Footnotes

  1. 76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codeboten
codeboten added this pull request to the merge queue Apr 17, 2026
Merged via the queue into open-telemetry:main with commit 7201768 Apr 17, 2026
65 of 66 checks passed
@axw
axw deleted the scraperherlper-controller-tests branch April 20, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants