[chore] Add aws/ec2 detector#15227
Conversation
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (83.01%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #15227 +/- ##
==========================================
- Coverage 91.13% 91.12% -0.01%
==========================================
Files 701 701
Lines 45781 45831 +50
==========================================
+ Hits 41722 41763 +41
- Misses 2845 2850 +5
- Partials 1214 1218 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 29.18%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | BenchmarkHTTPProtoLogsSequential |
3.7 ms | 5.1 ms | -27.36% |
| ❌ | BenchmarkGRPCLogsSequential |
4.4 ms | 6.3 ms | -29.18% |
Comparing iblancasa:14311-2 (8935586) with main (c64a66b)
Footnotes
-
76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
mx-psi
left a comment
There was a problem hiding this comment.
It seems fine to me to add this to the contrib distro, I am not sure if this should be in the core distro though. I understand that it is not easy currently to decide which distro to add this to (maybe through different telemetry providers?) but I do want to discuss that before moving forward with it
Fair concern. I was not sure neither how to proceed... for that reason decided to add first one of the detectors and wait for the feedback. What do you think about this?
|
Link to tracking issue
Updates #14311