Skip to content

[chore] Add aws/ec2 detector#15227

Closed
iblancasa wants to merge 3 commits into
open-telemetry:mainfrom
iblancasa:14311-2
Closed

[chore] Add aws/ec2 detector#15227
iblancasa wants to merge 3 commits into
open-telemetry:mainfrom
iblancasa:14311-2

Conversation

@iblancasa

Copy link
Copy Markdown
Member

Link to tracking issue

Updates #14311

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa
iblancasa requested a review from a team as a code owner April 29, 2026 15:13
@iblancasa
iblancasa requested a review from mx-psi April 29, 2026 15:13
@iblancasa iblancasa changed the title Add aws/ec2 detector [chore] Add aws/ec2 detector Apr 29, 2026
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.01887% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.12%. Comparing base (c64a66b) to head (8935586).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
service/telemetry/otelconftelemetry/resource.go 82.00% 5 Missing and 4 partials ⚠️

❌ Your patch status has failed because the patch coverage (83.01%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15227      +/-   ##
==========================================
- Coverage   91.13%   91.12%   -0.01%     
==========================================
  Files         701      701              
  Lines       45781    45831      +50     
==========================================
+ Hits        41722    41763      +41     
- Misses       2845     2850       +5     
- Partials     1214     1218       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Apr 30, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 29.18%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 5 untouched benchmarks
⏩ 76 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
BenchmarkHTTPProtoLogsSequential 3.7 ms 5.1 ms -27.36%
BenchmarkGRPCLogsSequential 4.4 ms 6.3 ms -29.18%

Comparing iblancasa:14311-2 (8935586) with main (c64a66b)

Open in CodSpeed

Footnotes

  1. 76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@mx-psi mx-psi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine to me to add this to the contrib distro, I am not sure if this should be in the core distro though. I understand that it is not easy currently to decide which distro to add this to (maybe through different telemetry providers?) but I do want to discuss that before moving forward with it

@iblancasa

Copy link
Copy Markdown
Member Author

It seems fine to me to add this to the contrib distro, I am not sure if this should be in the core distro though. I understand that it is not easy currently to decide which distro to add this to (maybe through different telemetry providers?) but I do want to discuss that before moving forward with it

Fair concern. I was not sure neither how to proceed... for that reason decided to add first one of the detectors and wait for the feedback.

What do you think about this?

  1. Wait until Allow enabling resource detectors via configuration #15226 is merged
  2. Expose reusable detector logic from core
  3. Add contrib telemetry package (would this follow the usual path for new packages in contrib?)
  4. We add it to the telemetry section from the manifest.

@iblancasa
iblancasa marked this pull request as draft April 30, 2026 11:19
@iblancasa iblancasa closed this May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants