[cmd/mdatagen] Implement numeric validation in generated Go config code (#14806) - #15270
Conversation
|
|
|
I wonder if this should also cover |
|
I don't think we have an existing use case for |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15270 +/- ##
==========================================
- Coverage 91.27% 91.27% -0.01%
==========================================
Files 709 709
Lines 46203 46218 +15
==========================================
+ Hits 42171 42184 +13
- Misses 2817 2818 +1
- Partials 1215 1216 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Head branch was pushed to by a user without write access
24c1814 to
6b8175e
Compare
ffa2bb1 to
ce877be
Compare
|
Thank you for approval @dmitryax , I fixed the linter issues (I forgot to run |
|
@blami please rebase and fix the CI failures |
|
@dmitryax done, can you re-run the CI? Also if there's a better way to ensure all is clean locally before pushing than just making sure there are no errors in |
bba407a to
06f1a53
Compare
|
@dmitryax Can you help me to start the CI workflows? Thanks. |
347e0ca to
1e78dd0
Compare
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Implements support for the JSON Schema numeric validation keywords 'minimum', 'maximum', 'exclusiveMaximum' and 'exclusiveMinimum' in mdatagen config generation pipeline. <!-- Issue number if applicable --> Fixes: open-telemetry#14806 <!--Describe what testing was performed and which tests were added.--> * Added unit tests in generation_test.go * The samplescraper golden file (`generated_config.go`) is updated to reflect the new generated output.
Implements support for the JSON Schema numeric validation keywords 'minimum', 'maximum', 'exclusiveMaximum' and 'exclusiveMinimum' in mdatagen config generation pipeline.
Fixes #14806
generated_config.go) is updated to reflect the new generated output.