Skip to content

[pkg/confighttp] Check snappy decoded length before read - #15271

Merged
dmitryax merged 3 commits into
open-telemetry:mainfrom
dmitryax:snappy-decoded-len-peek
May 8, 2026
Merged

[pkg/confighttp] Check snappy decoded length before read#15271
dmitryax merged 3 commits into
open-telemetry:mainfrom
dmitryax:snappy-decoded-len-peek

Conversation

@dmitryax

@dmitryax dmitryax commented May 7, 2026

Copy link
Copy Markdown
Member

Follow-up to #15253. No need for another changelog item

@dmitryax
dmitryax requested a review from a team as a code owner May 7, 2026 17:33
@dmitryax
dmitryax requested a review from evan-bradley May 7, 2026 17:33
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 7, 2026
@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.23%. Comparing base (8a98677) to head (6523540).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
config/confighttp/compression.go 42.85% 2 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (42.85%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15271      +/-   ##
==========================================
- Coverage   91.23%   91.23%   -0.01%     
==========================================
  Files         701      701              
  Lines       45873    45898      +25     
==========================================
+ Hits        41851    41873      +22     
- Misses       2819     2820       +1     
- Partials     1203     1205       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmitryax
dmitryax force-pushed the snappy-decoded-len-peek branch from 8ab0d8f to cfce3a7 Compare May 7, 2026 18:29
@songy23 songy23 added the ready-to-merge Code review completed; ready to merge by maintainers label May 7, 2026
@dmitryax
dmitryax added this pull request to the merge queue May 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 8, 2026
@dmitryax
dmitryax added this pull request to the merge queue May 8, 2026
Merged via the queue into open-telemetry:main with commit 56e1235 May 8, 2026
65 of 67 checks passed
@dmitryax
dmitryax deleted the snappy-decoded-len-peek branch May 8, 2026 03:01
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants