Refresh percentage memory limits after cgroup changes - #15608
Open
hooiv wants to merge 1 commit into
Open
Conversation
|
|
hooiv
force-pushed
the
feat/refresh-memorylimiter-cgroup-limits
branch
2 times, most recently
from
July 20, 2026 14:50
4c11b9c to
f45d115
Compare
Problem: percentage memory limits are resolved once at startup, so in-place container resizes leave the memory limiter enforcing stale thresholds. Solution: refresh cgroup-backed percentage thresholds on each memory check while retaining the previous thresholds when a refresh fails. Fixed MiB limits remain unchanged. Validation: go test . in internal/memorylimiter; go test . in processor/memorylimiterprocessor Signed-off-by: ADITYA CHAUHAN <125276621+hooiv@users.noreply.github.com>
hooiv
force-pushed
the
feat/refresh-memorylimiter-cgroup-limits
branch
from
July 20, 2026 14:50
f45d115 to
ab4ccfa
Compare
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Percentage-based
memorylimiterprocessorthresholds are resolved once at startup. When Kubernetes changes a container memory limit in place, the processor continues enforcing the stale thresholds.Solution
Refresh cgroup-backed percentage thresholds on each existing memory-check interval. If a refresh fails, retain the previous thresholds and log a warning. Fixed MiB limits are unchanged.
Addresses #15580.
Validation
go test .ininternal/memorylimitergo test .inprocessor/memorylimiterprocessorgit diff --checkSigned-off-by: ADITYA CHAUHAN hooiv@users.noreply.github.com